[proposal] trigger output change

[email protected] (Larry McVoy) Thu, 27 Apr 2006 11:42:41 -0700
Newsgroups gmane.comp.version-control.bitkeeper.user
Message-ID <[email protected]>
Right now, if you have multiple remote triggers that just echo their names
you would see

------ Remote trigger message --------------------------
I am trigger post-outgoing_1.
I am trigger post-outgoing_2.
I am trigger post-outgoing_3.
--------------------------------------------------------

We're considering changing that output for the upcoming release and making
it look like:


------ Remote trigger message --------------------------
Trigger "post-outgoing_1" says:
I am trigger post-outgoing_1.
Trigger "post-outgoing_2" says:
I am trigger post-outgoing_2.
Trigger "post-outgoing_3" says:
I am trigger post-outgoing_3.
--------------------------------------------------------

As well as also adding an extra line for any pre-trigger that exits non-zero
like so:

------ Remote trigger message --------------------------
Trigger "pre-incoming" exited 1.
--------------------------------------------------------

so that you can see which trigger produced which output and why an event
failed (if someone copies /bin/false to BitKeeper/triggers/pre-incoming
pushes will just start to silently fail which isn't polite).

Questions:

1.  Any objects to these changes?  If you are parsing trigger output this
    could break your scripts (but make future scripts easier).
2.  Any suggestions for better formats?  I thought of indenting each
    triggers output but wasn't sure that was the right answer.
-- 
---
Larry McVoy                lm at bitmover.com           http://www.bitkeeper.com