Re: [PATCH] move socket-related client parts into separate file

Alexey Mahotkin <[email protected]>
Newsgroups gmane.comp.version-control.cvs.bugs
Message-ID <[email protected]>
>>>>> "DRP" == Derek Robert Price <[email protected]> writes:

 DRP> Which part is lose-lose?  Supporting Windows?

I'm just scared that there are 300 lines which in principle could not be,
e.g. by switching Unix to recv() too.  Ok.

Oh!  Maybe should just get rid of #ifdef NO_SOCKET_TO_FD in
socket-client.c, so that it is always compile-checked, but only use
resulting buffer under Windows?  Let's think about it later.

 DRP> Committed, on top of Alexey's previous socket-client patch.

I just yesterday worked on refreshing all of this :) Ok, I'm sending
from_/to_server set of patches now.  Please consider.

In the evening I'll refresh logging buffer also, and one more patch to
socket-client (init_sockaddr() needs to be moved there too, to be used by
GSSAPI/Kerberos).

--alexm
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.