Re: [PATCH],refreshed: [2/3] rename global to_/from_server
Derek Robert Price <[email protected]>
| Newsgroups | gmane.comp.version-control.cvs.bugs |
|---|---|
| Organization | Ximbiot <http://ximbiot.com> |
| Message-ID | <[email protected]> |
Alexey Mahotkin wrote: >2003-05-02 Alexey Mahotkin <[email protected]> > >Rename global from_/to_server variables to global_from_server and >global_to_server, to emphasize their meaning (it was lost in the maze >of local ones and impostor from_/to_server_p variables). > > This is closer than your last few ChangeLog entries. A complete ChangeLog entry itemizes the changes by function, though. I do fudge this myself sometimes for changes like a global search/replace, but you still should have listed file names and maybe the names of the globals. Look at the way I've been rewriting your entries, perhaps. This one should be committed in an hour or so when the test finishes: > 2003-05-07 Derek Price <[email protected]> > > * client.c (from_server, to_server): Rename these global > buffer pointers to... > (global_from_server, global_to_server): ...this in order to avoid > confusion. > (Patch from Alexey Mahotkin <[email protected]>.) Thanks, Derek -- *8^) Email: [email protected] Get CVS support at <http://ximbiot.com>! -- Computer Lie #1: You'll never use all that disk space.