Re: Eclipse-compatible :extssh: method...
Derek Robert Price <[email protected]>
| Newsgroups | gmane.comp.version-control.cvs.bugs |
|---|---|
| Organization | Ximbiot <http://ximbiot.com> |
| Message-ID | <[email protected]> |
Deven T. Corzine wrote:
>On Wed, 7 May 2003, Derek Robert Price wrote:
>
>
>>Well, they probably should have talked to us.
>>
>>
>
>No argument here.
>
>
>
>>No, just most of them. With really vital stuff I sometimes find the
>>time to code that sort of thing myself.
>>
>>
>
>Why not do it for trivial stuff as well as vital stuff? If you can do it
>in a couple minutes, it shouldn't be a big deal. If you can't, then it's
>not trivial. :-)
>
I do do it for trivial stuff as well as vital stuff, sometimes, but a
lot of trivial fixes ends up taking up a lot of time.
In this particular case, however, I was also objecting to the nature of
the change. I think the voting developers will agree with me, this
patch just doesn't add enough functionality to justify the overhead.
Like I said, I'm guessing that the design goal here was to allow the
remote shell client to be encoded in the CVSROOT string. If the patch
did this in a more general way and came with test cases and docs, I
would probably commit it. At present I am taking the other voting
developer's silence for implicit acceptance of this. :)
>Well, since the "extssh" method I implemented is nearly identical to the
>"ext" method, whatever documentation and regression tests that the "ext"
>method uses should be trivial to copy and modify for ths "extssh" method.
>
>If I get a chance, I'll try to do that for you.
>
Again, sorry about that, but in this case it wouldn't be enough. If you
think you will have problems finding time to do this and it is important
to you, you might consider sending the report to whoever patched CVS for
Eclipse. If you can explain your problem to them and they think it
likely to affect other users, perhaps you can get them involved in this
discussion and perhaps submitting patches on their time.
>If you point me to the exact location of the documentation and regression
>tests for the "ext" method, that might let me expand on that patch more
>easily. Right now, I'd have to look for them.
>
All the tests are in src/sanity.sh. The "crerepos" tests are the only
ones that test :ext: and the CVS_RSH client specifically.
>>Again, sorry to disappoint.
>>
>>
>
>It's not a huge deal to me either way, but I suspect I'm not the only one
>who was bitten by the incompatibility between Eclipse and standard CVS...
>
>
Again, if not, then perhaps you can get some support from the people at
Eclipse.
Thanks again,
Derek
--
*8^)
Email: [email protected]
Get CVS support at <http://ximbiot.com>!
--
"I tried to think but nothing happened!"
- Curly