Re: PAM patch - final - ChangeLog additions

Derek Robert Price <[email protected]>
Newsgroups gmane.comp.version-control.cvs.bugs
Organization Ximbiot <http://ximbiot.com>
Message-ID <[email protected]>
Brian Murphy wrote:

> Hows this? 


These are pretty good, though the standard is to itemize the changes by 
function.  For cvs.texinfo, list the nodes that were changed instead of 
the functions.  For files like NEWS & INSTALL, list the section name.

Also, do you have autoconf installed on your system?  You listed the 
changes for config.h.in, but something like:

    *config.h.in: Regenerated.

is sufficient, since autoheader should have regenerated config.h.in 
based entirely on data in configure.in, provided you `./configure'd your 
workspace with `--enable-maintainer-mode'.  Just be clear about what 
changed in the configure.in entry.

> Patch in ordinary diff to protect against context changes.
> I didn't add my name - since I don't get to do the committing, what's 
> the usual
> procedure here?


People usually provide their name, though it doesn't matter.  It does 
give me something to copy & paste though, since I will credit you. 
 Otherwise I usually grab the name and email address of the contributor 
from the first email at hand.

Also, you don't need to provide the ChangeLog chunks as diffs, though 
you may continue to if you find it it easier.

Derek

-- 
                *8^)

Email: [email protected]

Get CVS support at <http://ximbiot.com>!
-- 
OPHELIA  Could beauty, my lord, have better commerce
  than with honesty?
HAMLET  Ay, truly.  For the power of beauty will sooner
  transform honesty from what it is to a bawd than the
  force of honesty can translate beauty into his likeness.
  This was sometime a paradox, but now the time gives it
  proof.  I did love you once.
OPHELIA  Indeed, my lord, you made me believe so.

     - Hamlet, Act III, Scene 1, Lines 109-116
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.