Re: mkstemp
Derek Robert Price <[email protected]>
| Newsgroups | gmane.comp.lib.gnulib.bugs,gmane.comp.version-control.cvs.bugs |
|---|---|
| Organization | Ximbiot <http://ximbiot.com> |
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Paul Eggert wrote: |Derek Robert Price <[email protected]> writes: | |>Perhaps it is silly to be working around bugs in glibc this old? It was |>fixed January 11, 1999. One could hope that the sysadmin in charge of |>the system on which CVS is being compiled has read the appropriate |>security notices and updated to a more recent version of glibc. | | |That's what I'd say, too. The problem affects all sorts of programs, |not just CVS. | |>Then again an extra chmod is pretty cheap. | | |I suspect that the chmod doesn't really fix the race condition. |Setting the umask before, and restoring it after, would probably be a |better fix; but I wouldn't bother. Thanks for the advice Paul! I removed the GLIBC compiler switch and the chmod from CVS 1.12.x and replaced it with what I hope is an informative comment about what used to happen and why anyone who wants to second-guess me should fiddle with the umask instead. I also added a comment to the NEWS file about upgrading to GLIBC version 2.0.7 or greater. Derek - -- ~ *8^) Email: [email protected] Get CVS support at <http://ximbiot.com>! - -- "It's difficult to work in a group when you're omnipotent." -Q, "Deja Q" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org iD8DBQE/XKPJLD1OTBfyMaQRAot6AJ9mrJ1TzA+ULTfNx2La7vOexHLi0wCg/VNC em7+2TXOMQbi60I8XhGmec4= =NZyd -----END PGP SIGNATURE-----