Re: Double-free bug in logmsg.c

"Mark D. Baushke" <[email protected]> Sat, 17 Jan 2004 22:40:18 -0800

Newsgroups	gmane.comp.version-control.cvs.general,gmane.comp.version-control.cvs.bugs
Message-ID	<[email protected]>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Gerald,

I have applied your patch to both the stable and development versions of
cvs.

	Thank you,
	-- Mark

Gerald Combs <[email protected]> writes:

> After running into segmentation faults and assertion failures in version
> 1.11.11, I managed to track down a double-free bug in logmsg.c.  A patch
> against the 1.11.11 sources is attached.
> --- logmsg.c.orig	2004-01-17 16:13:43.000000000 -0600
> +++ logmsg.c	2004-01-17 16:14:12.000000000 -0600
> @@ -551,6 +551,7 @@
>  	error (0, errno, "cannot remove %s", fname);
>      free (fname);
>      free( verifymsg_script );
> +    verifymsg_script = NULL;
>  }
>  
>  /*
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFACipR3x41pRYZE/gRAggiAKDipwdOZ6LYbxjl7/Sw90R8DTySpACgraYD
bOFbVL+3lPZaVMuKwihWvd4=
=BkhX
-----END PGP SIGNATURE-----