add cvs -W option to disable -R/CVSREADONLYFS

Norikatsu Shigemrua <[email protected]>
Newsgroups gmane.os.freebsd.devel.hackers,gmane.comp.version-control.cvs.bugs
Message-ID <[email protected]>
>Submitter-Id:  net
>Originator: 	Norikatsu Shigemura
>Organization:	net
>Confidential:  no
>Synopsis:	add cvs -W option to disable -R/CVSREADONLYFS
>Severity:	non-critical
>Priority:	low
>Category: 	cvs
>Class:		change-request
>Release:	1.12.5
>Environment:
System: FreeBSD melfina.ninth-nine.com 5.2-CURRENT FreeBSD 5.2-CURRENT #12: Sun Mar  7 21:11:13 JST 2004 [email protected]:/usr/obj/usr/src/sys/MELFINA i386

>Description:
	I added a feature which is to nagate a effect of -R/CVSREADONLYFS
	to cvs as -W option.  Please review and commit.
>How-To-Repeat:
	N/A
>Fix:
	Following patches are for cvs-1.12.5.
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
--- cvs-1.12.5/src/main.c.orig	Wed Nov 26 01:11:47 2003
+++ cvs-1.12.5/src/main.c	Tue Mar  9 19:50:09 2004
@@ -252,6 +252,7 @@ static const char *const opt_usage[] =
     "    -t           Show trace of program execution (repeat for more\n",
     "                 verbosity) -- try with -n.\n",
     "    -R           Assume repository is read-only, such as CDROM\n",
+    "    -W           Assume repository is writable (default).\n",
     "    -v           CVS version and copyright.\n",
     "    -T tmpdir    Use 'tmpdir' for temporary files.\n",
     "    -e editor    Use 'editor' for editing log information.\n",
@@ -423,7 +424,7 @@ main (int argc, char **argv)
     int help = 0;		/* Has the user asked for help?  This
 				   lets us support the `cvs -H cmd'
 				   convention to give help for cmd. */
-    static const char short_options[] = "+QqrwtnRvb:T:e:d:Hfz:s:xa";
+    static const char short_options[] = "+QqrwtnRWvb:T:e:d:Hfz:s:xa";
     static struct option long_options[] =
     {
         {"help", 0, NULL, 'H'},
@@ -563,6 +564,10 @@ main (int argc, char **argv)
 		break;
 	    case 'R':
 		readonlyfs = -1;
+		logoff = 1;
+		break;
+	    case 'W':
+		readonlyfs = 0;
 		logoff = 1;
 		break;
 	    case 'n':
--- cvs-1.12.5/man/cvs.1.orig	Sat Mar 29 01:02:33 2003
+++ cvs-1.12.5/man/cvs.1	Tue Mar  9 19:51:21 2004
@@ -243,7 +243,8 @@ Same effect as if the
 .SM CVSREADONLYFS
 environment variable is set.  Using
 .B \-R
-can also considerably speed up checkout's over NFS.
+can also considerably speed up checkout's over NFS.  If you want to disable
+this feature, you should specify -W option.
 .TP
 .B \-v [ --version ]
 Displays version and copyright information for
@@ -254,6 +255,10 @@ Makes new working files read-write (defa
 Overrides the setting of the
 .SM CVSREAD
 environment variable.
+.TP
+.B \-W
+Turns off read-only repository mode.  This is default mode, but it
+typically uses to negate the effect of -R option.
 .TP
 .B \-x
 Encrypt all communication between the client and the server.  As of
--- cvs-1.12.5/doc/cvs.texinfo.orig	Wed Dec 10 05:09:32 2003
+++ cvs-1.12.5/doc/cvs.texinfo	Tue Mar  9 19:53:16 2004
@@ -8151,7 +8151,12 @@ repository.
 
 Same effect as if the @code{CVSREADONLYFS} environment
 variable is set. Using @samp{-R} can also considerably
-speed up checkout's over NFS.
+speed up checkout's over NFS.  If you want to disable
+this feature, you should specify @samp{-W} option.
+
+@item -W
+Turns off read-only repository mode.  This is default mode,
+but it typically uses to negate the effect of @samp{-R} option.
 
 @cindex Read-only mode
 @item -n
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[email protected]"
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.