const qualifier violation in regex.c:re_comp()

Greetings,

The attached bug report was sent to [email protected], but really applies
to the :ext:[email protected]/cvsroot/gnulib repository
gnulib/lib/regex.c file.

	-- Mark

ChangeLog entry:

	* regex.c (re_comp): Use gettext_noop for constant strings.

Index: regex.c
===================================================================
RCS file: /cvsroot/gnulib/gnulib/lib/regex.c,v
retrieving revision 1.81
diff -u -p -u -p -r1.81 regex.c
--- regex.c	17 May 2004 05:41:42 -0000	1.81
+++ regex.c	4 Oct 2004 05:36:27 -0000
@@ -7906,7 +7906,7 @@ re_comp (const char *s)
   if (!s)
     {
       if (!re_comp_buf.buffer)
-	return gettext ("No previous regular expression");
+	return gettext_noop ("No previous regular expression");
       return 0;
     }
 

------- Forwarded Message -------

| Date: Fri, 1 Oct 2004 19:51:00 +0200 (CEST)
| From: Martin Neitzel <[email protected]>
| Message-Id: <[email protected]>
| To: [email protected]
| Subject: const qualifier violation in regex.c:re_comp()
| 
| 
| >Submitter-Id:   net
| >Originator: 	 Martin Neitzel
| >Organization:	Gaertner Datensysteme
| >Confidential:  no
| >Synopsis:	const qualifier violation in regex.c:re_comp()
| >Severity:	non-critical
| >Priority:	low
| >Category:	cvs
| >Class:		sw-bug
| >Release:	1.12.9.1
| >Environment:
| 	IRIX sco 5.3 11091810 IP12 mips
| 	(Probably any ANSI C build environment.)
| 
| >Description:
| 	lib/regex.c has a botched const char* (un)qualification.
| 
| >How-To-Repeat:
| 	Compile with all warnings taken seriously.
| 
| >Fix:
| 
| Index: lib/regex.c
| ===================================================================
| RCS file: /cvs/ccvs/lib/regex.c,v
| retrieving revision 1.14
| diff -u -r1.14 regex.c
| --- lib/regex.c	8 Apr 2004 01:35:59 -0000	1.14
| +++ lib/regex.c	1 Oct 2004 14:06:46 -0000
| @@ -7912,7 +7912,7 @@
|    if (!s)
|      {
|        if (!re_comp_buf.buffer)
| -	return gettext ("No previous regular expression");
| +	return gettext_noop ("No previous regular expression");
|        return 0;
|      }

------- End of Forwarded Message -------