Re: Re: const qualifier violation in regex.c:re_comp()

Martin Neitzel <[email protected]> Mon, 11 Oct 2004 23:19:29 +0200 (CEST)
Newsgroups gmane.comp.lib.gnulib.bugs,gmane.comp.version-control.cvs.bugs
Message-ID <[email protected]>
Gruezi Bruno et al.,

I was on a vacation trip, sory getting back so late.

Your analysis is absolutely correct.  I compiled the code using
--disable-nls and the original error message was:

cfe: Warning 709: regex.c, line 7915: Incompatible pointer type assignment
        return ((const char *) ("No previous regular expression")) ;
        ^

(With the declared return type of the function being "char *", and the
compiler showing the expanded gettext macro.)

I opted for the gettext_noop variation because it amounted to the same
overall effect (I now see just under --disable-nls) and because it
seemed to me to be in line with other places where gettext_noop is
used.  I actually considered the (char *) cast myself, and if you
prefer it, I certainly won't complain.

						Regards, Martin