CVS update: /ccvs/src/

User: dprice  
Date: 05/05/03 19:48:18

Modified:
 /ccvs/src/
  ChangeLog, tag.c

Log:
 * tag.c (is_in_val_tags): Remove unnecessary existance checking for the
 val-tags file and just rely on open() to create it when necessary.

File Changes:

Directory: /ccvs/src/
=====================

File [changed]: ChangeLog
Url: https://ccvs.cvshome.org/source/browse/ccvs/src/ChangeLog?r1=1.3185&r2=1.3186
Delta lines:  +5 -0
-------------------
--- ChangeLog	4 May 2005 02:38:48 -0000	1.3185
+++ ChangeLog	4 May 2005 02:48:16 -0000	1.3186
@@ -1,5 +1,10 @@
 2005-05-03  Derek Price  <[email protected]>
 
+	* tag.c (is_in_val_tags): Remove unnecessary existance checking for the
+	val-tags file and just rely on open() to create it when necessary.
+
+2005-05-03  Derek Price  <[email protected]>
+
 	* tag.c (tag_check_valid): Don't verify the_val_args.found when it is
 	not initialized.
 

File [changed]: tag.c
Url: https://ccvs.cvshome.org/source/browse/ccvs/src/tag.c?r1=1.139&r2=1.140
Delta lines:  +10 -23
---------------------
--- tag.c	4 May 2005 02:38:48 -0000	1.139
+++ tag.c	4 May 2005 02:48:16 -0000	1.140
@@ -1464,35 +1464,22 @@
 
     if (idb)
     {
-	db = dbm_open (valtags_filename, O_RDWR, 0666);
-	if (!db)
-	{
 	    mode_t omask;
 
-	    if (!existence_error (errno))
-	    {
-		error (0, errno, "warning: cannot open %s read/write",
-		       valtags_filename);
-		*idb = NULL;
-		return 1;
-	    }
-
 	    omask = umask (cvsumask);
-	    db = dbm_open (valtags_filename, O_RDWR | O_CREAT | O_TRUNC, 0666);
+	db = dbm_open (valtags_filename, O_RDWR | O_CREAT, 0666);
 	    umask (omask);
+
 	    if (!db)
 	    {
-		error (0, errno, "warning: cannot create %s",
+
+	    error (0, errno, "warning: cannot open `%s' read/write",
 		       valtags_filename);
 		*idb = NULL;
 		return 1;
 	    }
 
 	    *idb = db;
-	    return 0;
-	}
-
-	*idb = db;
     }
     else
     {