CVS update: /ccvs/src/

User: dprice  
Date: 05/05/09 11:26:54

Modified:
 /ccvs/src/
  ChangeLog, history.c

Log:
 * history.c (history_write): Add FIXME.

File Changes:

Directory: /ccvs/src/
=====================

File [changed]: ChangeLog
Url: https://ccvs.cvshome.org/source/browse/ccvs/src/ChangeLog?r1=1.3188&r2=1.3189
Delta lines:  +4 -0
-------------------
--- ChangeLog	9 May 2005 18:22:11 -0000	1.3188
+++ ChangeLog	9 May 2005 18:26:52 -0000	1.3189
@@ -1,5 +1,9 @@
 2005-05-09  Derek Price  <[email protected]>
 
+	* history.c (history_write): Add FIXME.
+
+2005-05-09  Derek Price  <[email protected]>
+
 	* hash.c (removenode, mergelists): New function.
 	(delnode): Use removenode.
 	* hash.h (mergelists): New proto.

File [changed]: history.c
Url: https://ccvs.cvshome.org/source/browse/ccvs/src/history.c?r1=1.90&r2=1.91
Delta lines:  +8 -1
-------------------
--- history.c	30 Apr 2005 03:55:07 -0000	1.90
+++ history.c	9 May 2005 18:26:52 -0000	1.91
@@ -869,7 +869,14 @@
     line = Xasprintf ("%c%08lx|%s|%s|%s|%s|%s\n", type, (long) time (NULL),
 		      username, workdir, repos, revs, name);
 
-    /* Lessen some race conditions on non-Posix-compliant hosts.  */
+    /* Lessen some race conditions on non-Posix-compliant hosts.
+     *
+     * FIXME:  I'm guessing the following was necessary for NFS when multiple
+     * simultaneous writes to the same file are possible, since NFS does not
+     * natively support append mode and it must be emulated via lseek().  Now
+     * that the history file is locked for write, the following lseek() may be
+     * unnecessary.
+     */
     if (lseek (fd, (off_t) 0, SEEK_END) == -1)
 	error (1, errno, "cannot seek to end of history file: %s", fname);