Re: RFH: testsuite Heisenbugs

Thorsten Glaser <[email protected]> Sat, 22 Oct 2016 18:52:36 +0000 (UTC)
Newsgroups gmane.comp.version-control.cvs.general
Message-ID <[email protected]>
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-164026070-1477162382=:30310
Content-Type: TEXT/PLAIN; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

Dixi quod=E2=80=A6

>Now, I=E2=80=99m suspecting a timing issue or something, so if anyone

=E2=80=A6 but while writing that, I saw this:

>=09Argument [34] Oct 1999 [0-9][0-9]:00:00 -0000

>=09Argument 3 Oct 1999 23:59:38 -0000

That made me curious, and indeed:

tg@blau:~ $ date; TZ=3DUTC0 date; TZ=3D date
Sat Oct 22 18:50:58 UTC 2016
Sat Oct 22 18:50:58 UTC 2016
Sat Oct 22 18:51:24 UTC 2016

So sanity.sh (which, IMHO, probably ought to have been called
insanity.sh instead =E2=98=BA) fails to properly restore an unset $TZ.

Fix attached for your convenience.

PASS: test-getdate.sh
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
All 1 tests passed
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Making check in diff
Making check in src
/usr/bin/make  check-local
/bin/mksh ./sanity.sh `pwd`/cvs
This test should produce no other output than this message, and a final "OK=
".
(Note that the test can take an hour or more to run and periodically stops
for as long as one minute.  Do not assume there is a problem just because
nothing seems to happen for a long time.  If you cannot live without
running status, try the command: `tail -f check.log' from another window.)
OK, all 3587 tests passed (11 test groups skipped).
/bin/mksh ./sanity.sh -r `pwd`/cvs
This test should produce no other output than this message, and a final "OK=
".
(Note that the test can take an hour or more to run and periodically stops
for as long as one minute.  Do not assume there is a problem just because
nothing seems to happen for a long time.  If you cannot live without
running status, try the command: `tail -f check.log' from another window.)
OK, all 3780 tests passed (1 test group skipped).
/bin/mksh ./sanity.sh -p `pwd`/cvs
This test should produce no other output than this message, and a final "OK=
".
(Note that the test can take an hour or more to run and periodically stops
for as long as one minute.  Do not assume there is a problem just because
nothing seems to happen for a long time.  If you cannot live without
running status, try the command: `tail -f check.log' from another window.)
OK, all 3614 tests passed (3 test groups skipped).

bye,
//mirabilos
--=20
=E2=80=9CIt is inappropriate to require that a time represented as
 seconds since the Epoch precisely represent the number of
 seconds between the referenced time and the Epoch.=E2=80=9D
=09-- IEEE Std 1003.1b-1993 (POSIX) Section B.2.2.2
--0-164026070-1477162382=:30310
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=sanity-fix.diff
Content-Transfer-Encoding: BASE64
Content-ID: <[email protected]>
Content-Description: 
Content-Disposition: attachment; filename=sanity-fix.diff

LS0tIHNyYy9zYW5pdHkuc2gJU2F0IE9jdCAyMiAxNTozNTowNyAyMDE2DQor
Kysgc3JjL3Nhbml0eS5zaAlTYXQgT2N0IDIyIDE1OjQwOjEyIDIwMTYNCkBA
IC0xLDUgKzEsNyBAQA0KICMhIC9iaW4vc2gNCiA6DQorIyAkTWlyT1M6IHNy
Yy9nbnUvdXNyLmJpbi9jdnMvc3JjL3Nhbml0eS5zaCx2IDEuNCAyMDE2LzEw
LzIyIDE1OjQwOjEyIHRnIEV4cCAkDQorIy0NCiAjIHNldCBESVNBQkxFX0FO
WV9SU0g9MSB0byBza2lwIHJzaCBhbmQgc3NoIGNhbGxzDQogIw0KICMJc2Fu
aXR5LnNoIC0tIGEgZ3Jvd2luZyB0ZXN0c3VpdGUgZm9yIGN2cy4NCkBAIC05
Miw2ICs5NCwyMyBAQCBjaGVja2xvbmdvcHRhcmcoKQ0KICAgICBmaQ0KIH0N
CiANCitkb19zYXZlX1RaKCkNCit7DQorCXNhdmVzZXRfVFo9JHtUWitmYWxz
ZX0NCisJc2F2ZV9UWj0kVFoNCisJVFo9VVRDMDsgZXhwb3J0IFRaDQorfQ0K
Kw0KK2RvX3Jlc3RvcmVfVFooKQ0KK3sNCisJaWYgJHNhdmVzZXRfVFogOjsg
dGhlbg0KKwkJdW5zZXQgVFoNCisJZWxzZQ0KKwkJVFo9JHNhdmVfVFoNCisJ
CWV4cG9ydCBUWg0KKwlmaQ0KK30NCisNCiAjIFNlZSBUT0RPIGxpc3QgYXQg
ZW5kIG9mIGZpbGUuDQogDQogIyByZXF1aXJlZCB0byBtYWtlIHRoaXMgc2Ny
aXB0IHdvcmsgcHJvcGVybHkuDQpAQCAtOTM3Niw4ICs5Mzk1LDcgQEAgYWRk
DQogCSAgIyBBbHNvIHRoZSAtZCBvcHRpb24uDQogDQogCSAgIyBTZXQgYSBw
cmVkaWN0YWJsZSB0aW1lIHpvbmUgZm9yIHRoZXNlIHRlc3RzLg0KLQkgIHNh
dmVfVFo9JFRaDQotCSAgVFo9VVRDMDsgZXhwb3J0IFRaDQorCSAgZG9fc2F2
ZV9UWg0KIA0KIAkgIG1rZGlyIDE7IGNkIDENCiAJICBta2RpciBhZGlyIGJk
aXIgY2Rpcg0KQEAgLTk1MDAsNyArOTUxOCw3IEBAIGltcG9ydC1pdA0KIAkg
IGRvdGVzdF9mYWlsIGltcG9ydGMtMTIgInRlc3QgLWQgJHtURVNURElSfS9v
dGhlciIgIiINCiANCiAJICBkb2tlZXANCi0JICBUWj0kc2F2ZV9UWg0KKwkg
IGRvX3Jlc3RvcmVfVFoNCiAJICBjZCAuLg0KIAkgIHJtIC1yIDEgMg0KIAkg
IG1vZGlmeV9yZXBvIHJtIC1yZiAkQ1ZTUk9PVF9ESVJOQU1FL2ZpcnN0LWRp
cg0KQEAgLTIyMTE5LDggKzIyMTM3LDcgQEAgJHtTUFJPR30gdXBkYXRlOiBV
cGRhdGluZyBjcmVyZXBvcy1kaXIiDQogDQogCSAgIyBTYXZlIHRoZSB0aW1l
em9uZSBhbmQgc2V0IGl0IHRvIFVUQyBmb3IgdGhlc2UgdGVzdHMgdG8gbWFr
ZSB0aGUNCiAJICAjIHZhbHVlIG1vcmUgcHJlZGljYXRhYmxlLg0KLQkgIHNh
dmVfVFo9JFRaDQotCSAgVFo9VVRDMDsgZXhwb3J0IFRaDQorCSAgZG9fc2F2
ZV9UWg0KIA0KIAkgIG1vZGlmeV9yZXBvIG1rZGlyICRDVlNST09UX0RJUk5B
TUUvZmlyc3QtZGlyDQogDQpAQCAtMjI1OTcsNyArMjI2MTQsNyBAQCByZXZp
c2lvbiAxXC41DQogcmV2aXNpb24gMVwuNCINCiANCiAJICBkb2tlZXANCi0J
ICBUWj0kc2F2ZV9UWg0KKwkgIGRvX3Jlc3RvcmVfVFoNCiAJICBjZCAuLg0K
IAkgIHJtIC1yIGZpcnN0LWRpcg0KIAkgIG1vZGlmeV9yZXBvIHJtIC1yZiAk
Q1ZTUk9PVF9ESVJOQU1FL2ZpcnN0LWRpcg0KQEAgLTIyNzg3LDggKzIyODA0
LDcgQEAgRU9GDQogCSAgIyByZXZpc2lvbnMgMS4xIGFuZCAxLjEuMS4xIGRp
ZmZlciBieSAxIHNlY29uZC4NCiANCiAJICAjIE5lZWQgYSBwcmVkaWN0YWJs
ZSB0aW1lIHpvbmUuDQotCSAgc2F2ZV9UWj0kVFoNCi0JICBUWj1VVEMwOyBl
eHBvcnQgVFoNCisJICBkb19zYXZlX1RaDQogDQogICAgICAgICAgIG1rZGly
IHJjczQNCiAgICAgICAgICAgY2QgcmNzNA0KQEAgLTIyODQ2LDcgKzIyODYy
LDcgQEAgRmlsZTogZmlsZTEgICAgICAgICAgICAJU3RhdHVzOiBVcC10by1k
YQ0KICAgIFN0aWNreSBPcHRpb25zOgkobm9uZSknDQogDQogCSAgZG9rZWVw
DQotCSAgVFo9JHNhdmVfVFoNCisJICBkb19yZXN0b3JlX1RaDQogCSAgY2Qg
Li4vLi4NCiAgICAgICAgICAgcm0gLXIgcmNzNA0KICAgICAgICAgICBtb2Rp
ZnlfcmVwbyBybSAtcmYgJENWU1JPT1RfRElSTkFNRS9yY3M0LWRpcg0KQEAg
LTI1NDM4LDggKzI1NDU0LDcgQEAgZG9uZSINCiAJICAjCQlmb3IgY2hlY2tv
dXQgYW5kIHVwZGF0ZSBhcyB3ZWxsLg0KIAkgICMNCiAJICBta2RpciAxOyBj
ZCAxDQotCSAgc2F2ZV9UWj0kVFoNCi0JICBUWj1VVEMwOyBleHBvcnQgVFoN
CisJICBkb19zYXZlX1RaDQogCSAgZG90ZXN0IHRhZ2RhdGUtMSAiJHt0ZXN0
Y3ZzfSAtcSBjbyAtbCAuIiAnJw0KIAkgIG1rZGlyIGZpcnN0LWRpcg0KIAkg
IGRvdGVzdCB0YWdkYXRlLTIgIiR7dGVzdGN2c30gYWRkIGZpcnN0LWRpciIg
XA0KQEAgLTI1OTAzLDcgKzI1OTE4LDcgQEAgRmlsZTogZmlsZTMgICAgICAg
ICAgICAJU3RhdHVzOiBVcC10by1kYQ0KIA0KIAkgIHVuc2V0IGRhdGVfVDEg
ZGF0ZV9UMiBkYXRlX1QzIGRhdGVfVDQgZGF0ZV9UNQ0KIAkgIHVuc2V0IGRh
dGVfVDYgZGF0ZV9UNyBkYXRlX1Q4IGRhdGVfVDkNCi0JICBUWj0kc2F2ZV9U
Wg0KKwkgIGRvX3Jlc3RvcmVfVFoNCiANCiAJICBkb2tlZXANCiAJICBybSAt
ciAxIDIgMyA0DQo=

--0-164026070-1477162382=:30310--