Re: Re: difference between LaunchViewer and LaunchEditor?

> I think it's better to use "open" verb. After all we are not trying to
> immitate Windows Explorer but give the user some flexibility with the
> files. He can exclplicitly invoke "edit" or "open" actions. If we used
> the default action we should not call the menu item Open but rather
> Execute. To keep things simple it's better to invoke the action as the
> menu suggests.

As you probably have received notification about already, I have now
uploaded a patch to the Files section containing all I've done so far. It
appears to be working (even though I couldn't say 100% for sure as shell
associations on my home machine are seriously screwed - time for a OS
reinstall - I'll check tomorrow on my work machine) but I think there is
still some (re-)organizational and cleanup work left to do. I have added
files containing notes about the changes I made (based on the WINCVS13b15
tag) and about what I think still needs doing to the uploaded archive.
Furthermore, I did not manage yet to make the new items in the context menu
visible or even available for customization.

I don't think that I'll have time enough during the next week to tackle all
this, so anyone else is free to finish the job in the meantime as far as I'm
concerned - otherwise I might have another go at it next weekend (or the
weekend after that or...).


> I was trying to provide some sort of clever shortcuts to enable edit
> or open, but you are right - Enter key should do same as double-click
> otherwise people will easily get confused.
>
> In the end, WinCvs is a tool for working on files which 99.99% of the
> time means editing them. There is no need to additional shortcuts for
> "Open" options - a menu items will suffice.

I have now used the following shortcuts:

Edit selection    Enter/DblClick
Edit with <editor>    Ctrl-Enter
Open selection    F7
Open with...    Ctrl-F7


> It's better to avoid the "Launch" in the name since it will be a
> Windows-specific function wrapper. It will also be confusing having
> the LaunchViewer and LaunchEditor around already. How about
> "ShellFileAction"?

That's what I changed it to now, but just before I finished I found another
existing use of ShellExecute that could be replaced by a call to the new
utility function, where Shell*File*Action doesn't really fit: Explore
Selection - reducing it to "ShellAction" seems a bit _too_ generic or isn't
it?

Concerning Jens' concern about a cross-platform interface for this, it
seemed that gCvs and MacCvs so far did not use LaunchViewer at all anyways
(the implementation just returned true without doing anything AFAICT), so I
don't know if this really makes sense as such.

Cheers,

Oliver
---- ------------------
JID: [email protected]
ICQ: 18777742      (http://wwp.icq.com/18777742)


------------------------ Yahoo! Groups Sponsor ---------------------~-->
Buy Ink Cartridges or Refill Kits for your HP, Epson, Canon or Lexmark
Printer at MyInks.com. Free s/h on orders $50 or more to the US & Canada.
http://www.c1tracking.com/l.asp?cid=5511
http://us.click.yahoo.com/mOAaAA/3exGAA/qnsNAA/NhFolB/TM
---------------------------------------------------------------------~->

To unsubscribe from this group, send an email to:
[email protected]

 

Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/