Re: Re: CvsAlert changes

Am 10.12.2003 um 04:42 schrieb Jerzy Kaczorowski:

> I just commited my changes to CvsAlert API. The function is replaced 
> with
> the class. The contructor looks similiar to the function but it 
> attempts to
> guess default button depending on the icon type and there is no 
> problem how
> to layout the parameters. It will also try to eliminate the Cancel 
> button
> title if the message is a "note" type.
>
> All that can be adjusted using the Get/Set methods if necessary.
>
> Additionally there is a preliminary support for "Don't show this again"
> checkbox which I will be putting to use soon. I still need to make some
> small resizing work in WinCvs alert dialog code (CCVSAlert_MAIN) but 
> common
> CvsAlert class is unlikely to change any more so you can go ahead and 
> fix
> the build for gCvs and MacCvs.
>
> I copied the function code into the CvsAlert::ShowAlert method. It 
> should be
> easy to fix the build by replacing the parameters with the CvsAlert 
> class
> members. The messages are stored as std::string values so you can test 
> the
> buttons and messages using the .empty() instead of checking the pointer
> against the NULL.

Just one modification I'd suggest: make CvsAlert::ShowAlert a const 
member function. That would allow streamlined code like e.g.
	CvsAlert("Some message").ShowAlert();
for basic error messages.

And another thing I noticed: there's a const std::string m_empty member 
in the CvsAlert class, but IMO, this could be a static member and 
shared between all instances of CvsAlert?

</jum>


[Non-text portions of this message have been removed]


------------------------ Yahoo! Groups Sponsor ---------------------~-->
Buy Ink Cartridges or Refill Kits for your HP, Epson, Canon or Lexmark
Printer at MyInks.com. Free s/h on orders $50 or more to the US & Canada.
http://www.c1tracking.com/l.asp?cid=5511
http://us.click.yahoo.com/mOAaAA/3exGAA/qnsNAA/NhFolB/TM
---------------------------------------------------------------------~->

To unsubscribe from this group, send an email to:
[email protected]

 

Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/