Re: Re: CvsAlert changes
Jens Miltner <[email protected]>
| Newsgroups | gmane.comp.version-control.cvs.gui.devel |
|---|---|
| Message-ID | <[email protected]> |
Am 10.12.2003 um 04:42 schrieb Jerzy Kaczorowski: > I just commited my changes to CvsAlert API. The function is replaced > with > the class. The contructor looks similiar to the function but it > attempts to > guess default button depending on the icon type and there is no > problem how > to layout the parameters. It will also try to eliminate the Cancel > button > title if the message is a "note" type. I'd prefer not to try and guess the default button, but rather always have the OK button the default button. Many questions that are posed are really safe to have the OK button as the default button and it's annoying to not have a quick shortcut by pressing Enter to confirm each question... IMO, it's much better to have a defined default behavior and decide at calling time whether that's o.k. or not and change this to Cancel if the operation is really _that_ critical. Instead, we might introduce a subclass of CvsAlert, e.g. CvsCriticalQuestion that will take a message as argument and make the cancel button the default. That would be just as convenient, but would leave some defined behavior in the base class. </jum> P.S: I changed the Mac implementation of AskYesNo and ConfirmMessage to use CvsAlert and I think this could probably become cross-platform (except for a small portion in AskYesNo where MacCvs makes sure the log window is visible and frontmost so it can be read behind the alert). You may want to take a look... [Non-text portions of this message have been removed] ------------------------ Yahoo! Groups Sponsor ---------------------~--> Buy Ink Cartridges or Refill Kits for your HP, Epson, Canon or Lexmark Printer at MyInks.com. Free s/h on orders $50 or more to the US & Canada. http://www.c1tracking.com/l.asp?cid=5511 http://us.click.yahoo.com/mOAaAA/3exGAA/qnsNAA/NhFolB/TM ---------------------------------------------------------------------~-> To unsubscribe from this group, send an email to: [email protected] Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/