Re: Re: CvsAlert changes

Jens, Kalle,

After I little thinking about the default button problem it occured to me
that I was approaching it from the wrond angle. I treated it as a state when
in fact it is a "behavioural" parameter. That prompts the following changes:

1. Remove the m_defaultButton from the CvsAlert members list and its access
interface.

It doesn't belong there and it only causes troubles!

2. Change the ShowAlert singnature like this:
virtual kCvsAlertButtonType ShowAlert(const kCvsAlertButtonType
defaultButton = kCvsAlertOKButton);

That change clearly indicates that default button is a behaviour and not the
data and defines the desired and expected in most cases default button and
stil keeps things simple to use.

In general I also have to agree that it's better to have the OK button set
as default regardles of the message type - hence kCvsAlertOKButton is used
here.

But I insist that the moving to trash should be an exception from that rule.
It's a very destructive and possibly irreversible (depending on the settings
of Recycke Bin etc.) operation and we can't hold the user responsible for
mistakes because the risk is too high. The erase operation is not intended
to be a rutine task anyway, so it will not really break the workflow and
it's probably even better to annoy the user at this point to stop a bad
habbit from developing ;)

I will be also moving the AskYesNo code to the AppGlue (with the
Mac-specific code of course). After we are done with the Alert changes I
will implement the storage of last few console lines by the cvsgui protocol
(and the special CVSNT formatting as well) so that code will not be
neccesary - we will have the message text right in the alert window where it
belongs. It's really against all guidelines to tell the user to search
somewhere else for error messages ;)

I will make the MoveToTrash using the OK/Cancel instead of Yes/No.

BTW: Thanks for the links to the GUI guidelines, I will take a good look at
these...

Best Regards,
Jerzy

------------------------ Yahoo! Groups Sponsor ---------------------~-->
Buy Ink Cartridges or Refill Kits for your HP, Epson, Canon or Lexmark
Printer at MyInks.com. Free s/h on orders $50 or more to the US & Canada.
http://www.c1tracking.com/l.asp?cid=5511
http://us.click.yahoo.com/mOAaAA/3exGAA/qnsNAA/NhFolB/TM
---------------------------------------------------------------------~->

To unsubscribe from this group, send an email to:
[email protected]

 

Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/