Re: Shell Edit continued...

> > - move ShellAction and ShellActionSucceeded to somewhere that's
> > available to all platforms
>
> Not yet done. Still waiting for input. CvsCommands would seem OK to me for
> that purpose, at least judging by what else is already there (that could
of
> course also be misplaced). Right now it's still in wincvs_winutils which
is
> obviously inappropriate for a supposed cross-platform function.

I have now moved it to CvsCommands for the time being. Still waiting for
comments.


> Done (bool LaunchHandler(const char* filePath, const kLaunchType
> launchType)). This obviously breaks/erases most of Jens' recent Mac
> additions. As LaunchHandler itself is pretty much void of
platform-specific
> code after my patch, that stuff should probably move to an ifdef inside
the
> new ShellAction function (see above).

I haven't deleted the LaunchEditor and LaunchViewer functions in the
uploaded patch yet, so Jens has still something to work with (I hope).


> Now, what I'm concerned about after some tests, is that changing the Open
> behaviour to "open" explicitly (as Jerzy proposed - before it used the
> empty/default action) causes the "Open as" dialog to be brought up much
more
> often than necessary. Just as an example, Visual C++ itself does create
> neither "edit" nor "open" associations for C/C++ source files (that's how
> consistently MS uses its own standards!). It only creates one custom
action
> named "Open with MSDev" which is not picked up by my new mechanism at all.
I
> think this latter part at least should be changed back to the old
behaviour
> (a middle-ground solution would probably be to try "open" first, then
> default and only if that also fails "openas").

I have for now implemented that latter approach. Still waiting for comments.


> - executing commands with Enter in the console pane no longer works

I finally managed to fix that one at least.


> I'm still doing some cleanup work at the moment. I'll post another
> intermediate patch as soon as that's done (hopefully about this time
> tomorrow) so you could properly see what I'm talking about.

Done now, as you have probably already received notification about. It's not
as cleaned up as I would have wished but I probably wouldn't have had time
to do it properly before next weekend and I wanted to let you see what I was
talking about.
The patch was made against the current tip of the trunk as of this writing.

Cheers,

Oliver
----  ------------------
JID:  [email protected]
ICQ:  18777742     (http://wwp.icq.com/18777742)


 

Yahoo! Groups Links

To visit your group on the web, go to:
 http://groups.yahoo.com/group/cvsgui-dev/

To unsubscribe from this group, send an email to:
 [email protected]

Your use of Yahoo! Groups is subject to:
 http://docs.yahoo.com/info/terms/