Re: Launch* functions moved

"Jerzy Kaczorowski" <[email protected]>
Newsgroups gmane.comp.version-control.cvs.gui.devel
Message-ID <[email protected]>
Oliver,

>Sounds good to me.
>Also OK... not sure which one I'd prefer really...

You are NOT helping ;)

Well, we can do both actually.

>But you still agree that the Edit item should be the new
>double-click action?
>(snip...)
>The significant change that we must take precautions
>against is that of the double-click behaviour which has
>no label and will thus be unexpected...

I agree for now. Let's give it a try and see what people say, it's
easy to change that at any time.

>I think I saw mention of an API for opening up the
>association dialog though...

That would be good to have.

>P.S.: I saw that you kept and even adjusted the LaunchEditor and
>LaunchViewer functions even though they are really obsolete now.
>As I mentioned before the only reason I did not remove them from
>my patch already was not to invalidate all of Jens' work... they have
>no more purpose at all as all calls to them have been replaced with
>appropriately parameterized calls to LaunchHandler instead now....

I decided to keep that for now for the same reasons. But the move to the
separate files is not a coincidence - I spent some time contemplating even
more generic solution with class hierarchy similiar to the selection
handlers
used for CVS commands found in BrowseViewHandlers.h/cpp. I am happy
with the functionality and we will clean up eventually by which time I
should
make up my mind about class hierarchy.

Best Regards,
Jerzy


 

------------------------ Yahoo! Groups Sponsor ---------------------~-->
Upgrade to 128-bit SSL Security!
http://us.click.yahoo.com/qZ0LdD/yjVHAA/TtwFAA/NhFolB/TM
---------------------------------------------------------------------~->

Yahoo! Groups Links

To visit your group on the web, go to:
 http://groups.yahoo.com/group/cvsgui-dev/

To unsubscribe from this group, send an email to:
 [email protected]

Your use of Yahoo! Groups is subject to:
 http://docs.yahoo.com/info/terms/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.