Re: Don't define _i18n to _T...

Hiroaki,

>This is wrong, because _T is a way for switching between
>non-UNICODE builds and UNICODE builds, not for nls,
>Such define avoids supporting nls for WinCvs.

Does that cause any real problem?

WinCvs doesn't support UNICODE build but it is easier to use i18n() and get
the _T() everywhere this way - alternative would be to have no _i18n() for
windows build and just a plain strings but that doesn't help with anything.
So until we start supporting i18n properly we can just as well have the
_i18n expand to _T temporarily and we can change it later on.

>By the way, is nls-support on WinCvs in Jerzy's plan?
>Maybe I can supply a nls-patch, because I already have
>a nls-patch for CVS client. (libintl for Windows is
>already available.)

I am not able to support any particular version so it can only happen if
there is a person to maintain. So if you are ready for such commitment I
would simply give you the write access to the repository so you could apply
the changes ;)

How big is the change? Does it require some changes to CVSNT(cvs.exe) binary
as well?

Best Regards,
Jerzy

----- Original Message ----- 
From: Hiroaki Itoh
To: [email protected]
Sent: Thursday, March 04, 2004 13:40
Subject: [cvsgui-dev] Don't define _i18n to _T...


In cvsgui_i18n.h:
-------------------
#ifdef WIN32
#  define _i18n _T
#else
-------------------
This is wrong, because _T is a way for switching between
non-UNICODE builds and UNICODE builds, not for nls,
in WIN32. Such define avoids supporting nls for WinCvs.

By the way, is nls-support on WinCvs in Jerzy's plan?
Maybe I can supply a nls-patch, because I already have
a nls-patch for CVS client. (libintl for Windows is
already available.)


------------------------ Yahoo! Groups Sponsor ---------------------~-->
Buy Ink Cartridges or Refill Kits for your HP, Epson, Canon or Lexmark
Printer at MyInks.com. Free s/h on orders $50 or more to the US & Canada.
http://www.c1tracking.com/l.asp?cid=5511
http://us.click.yahoo.com/mOAaAA/3exGAA/qnsNAA/NhFolB/TM
---------------------------------------------------------------------~->

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
     http://groups.yahoo.com/group/cvsgui-dev/

<*> To unsubscribe from this group, send an email to:
     [email protected]

<*> Your use of Yahoo! Groups is subject to:
     http://docs.yahoo.com/info/terms/