Fix title when refresh for not existing folder
"kaczoroj" <[email protected]> Wed, 12 May 2004 23:02:39 -0000
| Newsgroups | gmane.comp.version-control.cvs.gui.devel |
|---|---|
| Message-ID | <[email protected]> |
Karl, Jens,
I checked in the fix for the invalid title when refresh for not
existing folder in WinCvs and then it turned out that gCvs and MacCvs
ought to have the same bug I did that too.
The problem is in the UCvsFolders.cpp in line 571. It used to look
like that:
UCvsApp::gApp->GetFilesView()->ResetView(path, false);
The problem is that "path" may point to the wrong place due to the
DeleteAllItems call at the function entry. For that the path is copied
into the local variable, namely "pathCopy". All is to do is to use it
as that one place was missed out somehow. It now looks like that:
UCvsApp::gApp->GetFilesView()->ResetView(pathCopy, false);
That is a tricky bug as it may not immediately show - there is a good
chance that the memory still contains valid string and it looks OK but
it for anyone to take and in some cases title will go terribly wrong ;
)
Please verify that fix works OK...
Best Regards,
Jerzy
------------------------ Yahoo! Groups Sponsor ---------------------~-->
Make a clean sweep of pop-up ads. Yahoo! Companion Toolbar.
Now with Pop-Up Blocker. Get it for free!
http://us.click.yahoo.com/L5YrjA/eSIIAA/yQLSAA/NhFolB/TM
---------------------------------------------------------------------~->
Yahoo! Groups Links
<*> To visit your group on the web, go to:
http://groups.yahoo.com/group/cvsgui-dev/
<*> To unsubscribe from this group, send an email to:
[email protected]
<*> Your use of Yahoo! Groups is subject to:
http://docs.yahoo.com/info/terms/