Re: Fix title when refresh for not existing folder

Am 13.05.2004 um 01:02 schrieb kaczoroj:

> Karl, Jens,
>
> I checked in the fix for the invalid title when refresh for not
> existing folder in WinCvs and then it turned out that gCvs and MacCvs
> ought to have the same bug I did that too.
>
> The problem is in the UCvsFolders.cpp in line 571. It used to look
> like that:
>
> UCvsApp::gApp->GetFilesView()->ResetView(path, false);
>
> The problem is that "path" may point to the wrong place due to the
> DeleteAllItems call at the function entry. For that the path is copied
> into the local variable, namely "pathCopy". All is to do is to use it
> as that one place was missed out somehow. It now looks like that:
>
> UCvsApp::gApp->GetFilesView()->ResetView(pathCopy, false);
>
> That is a tricky bug as it may not immediately show - there is a good
> chance that the memory still contains valid string and it looks OK but
> it for anyone to take and in some cases title will go terribly wrong ;
> )
>
> Please verify that fix works OK...

Jerzy,

can you explain how to trigger this bug (in the version that's not yet 
fixed)?

Thanks
</jum>



------------------------ Yahoo! Groups Sponsor ---------------------~-->
Yahoo! Domains - Claim yours for only $14.70
http://us.click.yahoo.com/Z1wmxD/DREIAA/yQLSAA/NhFolB/TM
---------------------------------------------------------------------~->

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
     http://groups.yahoo.com/group/cvsgui-dev/

<*> To unsubscribe from this group, send an email to:
     [email protected]

<*> Your use of Yahoo! Groups is subject to:
     http://docs.yahoo.com/info/terms/