Re: Re: Fix title when refresh for not existing folder

Am 13.05.2004 um 22:29 schrieb kaczoroj:

> Jens,
>
>> Sorry for my ignorance, but how would you set the browse
>> location to a non-existing folder?
>
> Of course you set it to an existing location first and then remove the
> folder. Such location is still OK, all-empty display of course.
>
> There is no direct entry - it has to be selected by browsing. This is
> probably why this bug went undetected for so long ;)

Uuuh, aaah, yes - I see.
Crashes MacCvs nicely, too ;-)
Although it crashed in another place (since it's crashing in some 
Mac-only code).

While trying to fix this and verify your changes, I found that some of 
the changes you(?) did to MultiString.h really cause serious problems 
for MacCvs:
(1) You've made the declaration of list_t in TMPersistent privat, so no 
subclass can access it. I think it should be at least protected...

(2) You moved the implementation of the member functions into the .cp 
file. This is a problem for templated classes, since anybody who wants 
to instantiate such a template class needs the implementation in order 
to instantiate the template. However, the .cp file contains much more 
than just those implementations, so it can't just be included from 
another file.
Unfortunately, MacCvs uses an instance of TMPersistent and the template 
parameter is such that it can't easily be instantiated inside 
MultiString.cpp.
For templated classes, it really, really makes sense to put the 
implementation of member functions in the header file, otherwise nobody 
will be able to instantiate custom instances!

I've fixed a couple of other issues but got stuck with this one. I've 
committed my changes thus far and will now wait for your comments on 
this issue...

</jum>


[Non-text portions of this message have been removed]



 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
     http://groups.yahoo.com/group/cvsgui-dev/

<*> To unsubscribe from this group, send an email to:
     [email protected]

<*> Your use of Yahoo! Groups is subject to:
     http://docs.yahoo.com/info/terms/