Re: gCvs pathes
[email protected] Wed, 15 Dec 2004 23:17:22 -0000
| Newsgroups | gmane.comp.version-control.cvs.gui.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Richard, So can we close as commited to GTK-2 branch: - 1024525 compilation error caused by getopt.h - 1024520 TCL_LIBS ignored And then we close as obsolete: - 1024512 Missing -I - 1024511 update cvsunix/configure.in for autoconf-2.5 The cvsunix dir which is obsolete is probably best to be treated "cvs remove" if it's not used in the build. I am not sure it's not used by MacCvs build... BTW: Don't change the modules file in CVSROOT repo so the previous versions can be still checked out. JK> 1041198 gCvs always says the cvs executable has no support for GUI >already closed... Thanks! Best Regards, Jerzy ----- Original Message ----- Wrom: QHYUCDDJBLVLM To: Jerzy Kaczorowski Cc: [email protected] Sent: Wednesday, December 15, 2004 8:52 Subject: Re: [cvsgui-dev] gCvs pathes Hello Jerzy, Wednesday, December 15, 2004, 1:43:04 AM, you wrote: JK> There are few gCvs pathes that seem to be easy to either apply or close. JK> I am talking about thomasklausner patches: JK> 1024525 compilation error caused by getopt.h this is IMHO not the correct way to fix. The way configure replaced system functions are handled by WinCvs is not quite the recomended way. Files like getopt.[ch], getline.[ch], fnmatch.[ch] and the like hve to be moved from the common dir to a separate dir. Than the configure.in has to be adapted to dynamicaly include the missing files in a lib. Fixing this will impact all CvsGuis, also cvstree has to be fixed, cause it is not using config.h in all places. I have done this in the gCvs-GTK-2 branch already. JK> 1024520 TCL_LIBS ignored Ok. Comitted... JK> 1024512 Missing -I This is in the cvsunix subdir - see below... JK> 1024511 update cvsunix/configure.in for autoconf-2.5 The cvsunix dir is marked NO-AUTO-GEN. So it is excluded from the current builds. And it is a rather old cvs version. I wonder if we realy should maintain this old stuff any more? JK> 1024525 has a comment that most patches are applied already in the repo, it JK> would be best to get them out of the picture if that is the case and if not JK> then apply them. JK> There is also the patch from guyr: JK> 1041198 gCvs always says the cvs executable has no support for GUI already closed... -- Best regards, Richard mailto:[email protected] ------------------------ Yahoo! Groups Sponsor --------------------~--> Make a clean sweep of pop-up ads. Yahoo! Companion Toolbar. Now with Pop-Up Blocker. Get it for free! http://us.click.yahoo.com/L5YrjA/eSIIAA/yQLSAA/NhFolB/TM --------------------------------------------------------------------~-> Yahoo! Groups Links <*> To visit your group on the web, go to: http://groups.yahoo.com/group/cvsgui-dev/ <*> To unsubscribe from this group, send an email to: [email protected] <*> Your use of Yahoo! Groups is subject to: http://docs.yahoo.com/info/terms/