Re: compiling WinCVS on VS.NET 2003
"kaczoroj" <[email protected]> Mon, 06 Feb 2006 00:50:52 -0000
| Newsgroups | gmane.comp.version-control.cvs.gui.devel |
|---|---|
| Message-ID | <[email protected]> |
Arthur, Thanks for the patch, however this is not the best place to send these. List is mainly for discussions. Mails tend to get lost or forgotten or whatever so the best place for any patches would be the cvsgui project patches area where it will be handled sooner or later and at least it will not be lost. Here is the link: https://sourceforge.net/tracker/? atid=310072&group_id=10072&func=browse I will check that with VS.NET but I have one note - patches normally don't contain ChangeLog entry. We normally write a person actually commiting the change and for patches a credit is given in the form "patch submitted by ..." note. I think Richard has already checked in some fixes for VS.NET build so I am not sure what is the overlap here - will check and revert back. Best Regards, Jerzy --- In [email protected], "Arthur Barrett" <arthur.barrett@. ..> wrote: > > Hi All. > > Noticed a few people have been trying to compile WinCVS on VS.NET 2003 > so thought I'd submit patches to show how. > > You need to do the auto conversion of the projects/workspaces, then fix > these (based on trunk which I think is 2.0.3 ?): > > *** ChangeLog 9 Jan 2006 12:18:26 -0000 1.958 > --- ChangeLog 3 Feb 2006 05:48:27 -0000 > *************** > *** 1,3 **** > --- 1,9 ---- > + Fri Feb 03 2006 Arthur Barrett <abarrett@... > <mailto:abarrett@...> > > + * WinCvs 2.0.3 > + - upgrade code to compaile on vs.net 2003 > + fixed misuse of constructor std::istrstream > + changed spin control CSpinButtonCtrl to use SetRange32 (was > SetRange) > + > Mon Jan 09 2006 Richard Wirth <gcvs@... > <mailto:gcvs@...> > > * WinCvs 2.0.3 > - attempt to compile with vs.net 2003 > > *** common/CvsRootDlg.cpp 9 Jan 2006 12:04:31 -0000 1.13 > --- common/CvsRootDlg.cpp 3 Feb 2006 01:15:23 -0000 > *************** > *** 100,108 **** > } > > /// Get the command result > ! istrstream CCvsRootConsole::GetCvsOut() const > { > ! return istrstream(&(*m_cvsOutVec.begin()), m_cvsOutVec.size()); > } > > /// Set the command result > --- 100,108 ---- > } > > /// Get the command result > ! char * CCvsRootConsole::GetCvsOut() const > { > ! return istrstream(&(*m_cvsOutVec.begin()), m_cvsOutVec.size()). str(); > } > > /// Set the command result > *************** > *** 113,121 **** > } > > /// Get the error result > ! istrstream CCvsRootConsole::GetCvsErr() const > { > ! return istrstream(&(*m_cvsErrVec.begin()), m_cvsErrVec.size()); > } > > > //////////////////////////////////////////////////////////////////// //// > // > --- 113,121 ---- > } > > /// Get the error result > ! char * CCvsRootConsole::GetCvsErr() const > { > ! return istrstream(&(*m_cvsErrVec.begin()), m_cvsErrVec.size()). str(); > } > > > //////////////////////////////////////////////////////////////////// //// > // > *************** > *** 135,141 **** > > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 135,141 ---- > > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 203,209 **** > > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 203,209 ---- > > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 940,946 **** > > string line; > > ! istrstream myCvsErr = infoParserConsole.GetCvsErr(); > > while( getline(myCvsErr, line) ) > { > --- 940,946 ---- > > string line; > > ! istrstream myCvsErr ( infoParserConsole.GetCvsErr() ); > > while( getline(myCvsErr, line) ) > { > *************** > *** 1000,1006 **** > > string line; > > ! istrstream myCvsErr = protocolParserConsole.GetCvsErr(); > > while( getline(myCvsErr, line) ) > { > --- 1000,1006 ---- > > string line; > > ! istrstream myCvsErr ( protocolParserConsole.GetCvsErr() ); > > while( getline(myCvsErr, line) ) > { > > *** common/CvsRootDlg.h 12 Oct 2005 20:53:35 -0000 1.9 > --- common/CvsRootDlg.h 3 Feb 2006 01:16:24 -0000 > *************** > *** 88,96 **** > > public: > int GetLaunchRes() const; > ! istrstream GetCvsOut() const; > void SetCvsOut(const char* str, int lLen); > ! istrstream GetCvsErr() const; > }; > > /// Class to parse protocols available (obtained using <b>cvs > info</b>) > --- 88,96 ---- > > public: > int GetLaunchRes() const; > ! char * GetCvsOut() const; > void SetCvsOut(const char* str, int lLen); > ! char * GetCvsErr() const; > }; > > /// Class to parse protocols available (obtained using <b>cvs > info</b>) > > *** common/FilterMaskOptDlg.cpp 18 Jun 2004 03:44:50 -0000 1.4 > --- common/FilterMaskOptDlg.cpp 3 Feb 2006 00:58:55 -0000 > *************** > *** 79,85 **** > CHHelpDialog::OnInitDialog(); > > // Extra initialization > ! m_reactionSpeedSpin.SetRange(0, 1000000); > > UpdateReactionSpeedInfo(); > > --- 79,85 ---- > CHHelpDialog::OnInitDialog(); > > // Extra initialization > ! m_reactionSpeedSpin.SetRange32(0, 1000000); > > UpdateReactionSpeedInfo(); > > > *** common/ItemListDlg.cpp 9 Jan 2006 12:04:31 -0000 1.35 > --- common/ItemListDlg.cpp 3 Feb 2006 01:15:23 -0000 > *************** > *** 122,128 **** > > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 122,128 ---- > > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 228,234 **** > { > bool res = false; > > ! istrstream myCvsOut = GetCvsOut(); > > string line; > while( getline(myCvsOut, line) ) > --- 228,234 ---- > { > bool res = false; > > ! istrstream myCvsOut ( GetCvsOut() ); > > string line; > while( getline(myCvsOut, line) ) > *************** > *** 254,260 **** > string line; > string partialLine; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 254,260 ---- > string line; > string partialLine; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 296,302 **** > > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 296,302 ---- > > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 410,416 **** > { > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 410,416 ---- > { > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 1349,1355 **** > EnableControls(TRUE); > > // Display data > ! istrstream myCvsErr = itemListConsole->GetCvsErr(); > DisplayItems(itemListConsole->GetItemList(), > itemListConsole->GetLaunchRes(), &myCvsErr); > > --- 1349,1355 ---- > EnableControls(TRUE); > > // Display data > ! istrstream myCvsErr ( itemListConsole->GetCvsErr() ); > DisplayItems(itemListConsole->GetItemList(), > itemListConsole->GetLaunchRes(), &myCvsErr); > > > Regards, > > > > Arthur > > ---------- > > > *** ChangeLog 9 Jan 2006 12:18:26 -0000 1.958 > --- ChangeLog 3 Feb 2006 05:48:27 -0000 > *************** > *** 1,3 **** > --- 1,9 ---- > + Fri Feb 03 2006 Arthur Barrett <abarrett@...> > + * WinCvs 2.0.3 > + - upgrade code to compaile on vs.net 2003 > + fixed misuse of constructor std::istrstream > + changed spin control CSpinButtonCtrl to use SetRange32 (was SetRange) > + > Mon Jan 09 2006 Richard Wirth <gcvs@...> > * WinCvs 2.0.3 > - attempt to compile with vs.net 2003 > > *** common/CvsRootDlg.cpp 9 Jan 2006 12:04:31 -0000 1.13 > --- common/CvsRootDlg.cpp 3 Feb 2006 01:15:23 -0000 > *************** > *** 100,108 **** > } > > /// Get the command result > ! istrstream CCvsRootConsole::GetCvsOut() const > { > ! return istrstream(&(*m_cvsOutVec.begin()), m_cvsOutVec.size()); > } > > /// Set the command result > --- 100,108 ---- > } > > /// Get the command result > ! char * CCvsRootConsole::GetCvsOut() const > { > ! return istrstream(&(*m_cvsOutVec.begin()), m_cvsOutVec.size()). str(); > } > > /// Set the command result > *************** > *** 113,121 **** > } > > /// Get the error result > ! istrstream CCvsRootConsole::GetCvsErr() const > { > ! return istrstream(&(*m_cvsErrVec.begin()), m_cvsErrVec.size()); > } > > ////////////////////////////////////////////////////////////////// //////// > --- 113,121 ---- > } > > /// Get the error result > ! char * CCvsRootConsole::GetCvsErr() const > { > ! return istrstream(&(*m_cvsErrVec.begin()), m_cvsErrVec.size()). str(); > } > > ////////////////////////////////////////////////////////////////// //////// > *************** > *** 135,141 **** > > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 135,141 ---- > > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 203,209 **** > > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 203,209 ---- > > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 940,946 **** > > string line; > > ! istrstream myCvsErr = infoParserConsole. GetCvsErr(); > > while( getline(myCvsErr, line) ) > { > --- 940,946 ---- > > string line; > > ! istrstream myCvsErr ( infoParserConsole. GetCvsErr() ); > > while( getline(myCvsErr, line) ) > { > *************** > *** 1000,1006 **** > > string line; > > ! istrstream myCvsErr = protocolParserConsole. GetCvsErr(); > > while( getline(myCvsErr, line) ) > { > --- 1000,1006 ---- > > string line; > > ! istrstream myCvsErr ( protocolParserConsole. GetCvsErr() ); > > while( getline(myCvsErr, line) ) > { > > *** common/CvsRootDlg.h 12 Oct 2005 20:53:35 -0000 1.9 > --- common/CvsRootDlg.h 3 Feb 2006 01:16:24 -0000 > *************** > *** 88,96 **** > > public: > int GetLaunchRes() const; > ! istrstream GetCvsOut() const; > void SetCvsOut(const char* str, int lLen); > ! istrstream GetCvsErr() const; > }; > > /// Class to parse protocols available (obtained using <b>cvs info</b>) > --- 88,96 ---- > > public: > int GetLaunchRes() const; > ! char * GetCvsOut() const; > void SetCvsOut(const char* str, int lLen); > ! char * GetCvsErr() const; > }; > > /// Class to parse protocols available (obtained using <b>cvs info</b>) > > *** common/FilterMaskOptDlg.cpp 18 Jun 2004 03:44:50 -0000 1.4 > --- common/FilterMaskOptDlg.cpp 3 Feb 2006 00:58:55 -0000 > *************** > *** 79,85 **** > CHHelpDialog::OnInitDialog(); > > // Extra initialization > ! m_reactionSpeedSpin.SetRange(0, 1000000); > > UpdateReactionSpeedInfo(); > > --- 79,85 ---- > CHHelpDialog::OnInitDialog(); > > // Extra initialization > ! m_reactionSpeedSpin.SetRange32(0, 1000000); > > UpdateReactionSpeedInfo(); > > > *** common/ItemListDlg.cpp 9 Jan 2006 12:04:31 -0000 1.35 > --- common/ItemListDlg.cpp 3 Feb 2006 01:15:23 -0000 > *************** > *** 122,128 **** > > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 122,128 ---- > > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 228,234 **** > { > bool res = false; > > ! istrstream myCvsOut = GetCvsOut(); > > string line; > while( getline(myCvsOut, line) ) > --- 228,234 ---- > { > bool res = false; > > ! istrstream myCvsOut ( GetCvsOut() ); > > string line; > while( getline(myCvsOut, line) ) > *************** > *** 254,260 **** > string line; > string partialLine; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 254,260 ---- > string line; > string partialLine; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 296,302 **** > > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 296,302 ---- > > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 410,416 **** > { > string line; > > ! istrstream myCvsOut = GetCvsOut(); > > while( getline(myCvsOut, line) ) > { > --- 410,416 ---- > { > string line; > > ! istrstream myCvsOut ( GetCvsOut() ); > > while( getline(myCvsOut, line) ) > { > *************** > *** 1349,1355 **** > EnableControls(TRUE); > > // Display data > ! istrstream myCvsErr = itemListConsole->GetCvsErr(); > DisplayItems(itemListConsole->GetItemList(), > itemListConsole->GetLaunchRes(), &myCvsErr); > > --- 1349,1355 ---- > EnableControls(TRUE); > > // Display data > ! istrstream myCvsErr ( itemListConsole->GetCvsErr() ); > DisplayItems(itemListConsole->GetItemList(), > itemListConsole->GetLaunchRes(), &myCvsErr); > > > > > [Non-text portions of this message have been removed] > Yahoo! Groups Links <*> To visit your group on the web, go to: http://groups.yahoo.com/group/cvsgui-dev/ <*> To unsubscribe from this group, send an email to: [email protected] <*> Your use of Yahoo! Groups is subject to: http://docs.yahoo.com/info/terms/