array new[] bug in Utils/StringUtils.cpp
Adrian Buehlmann <[email protected]>
| Newsgroups | gmane.comp.version-control.cvs.tortoisecvs.user |
|---|---|
| Message-ID | <[email protected]> |
Hi all (this is intended for the TortoiseCVS developers, sorry if this is the wrong list -- I haven't found a -devel list) We seem to have been taken the StringUtils.cpp of TortoiseCVS for TortoiseHg [1]. I noticed there is an array new / delete bug in WideToMultibyte and MultibyteToWide (new[] must be paired with delete[], which is not). I checked your http://tortoisecvs.cvs.sourceforge.net/viewvc/tortoisecvs/TortoiseCVS/src/Utils/StringUtils.cpp?revision=1.31&view=markup and noticed it has the same bug. The fix I used for TortoiseHg is http://bitbucket.org/abuehl/thg-stable/changeset/51bee82d4b6f/raw/thg-stable-51bee82d4b6f.diff in case you are interested. Adrian [1] http://bitbucket.org/tortoisehg/stable/wiki/Home ------------------------------------------------------------------------------ Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org