Re: TortoiseCVS RC4 patches

Torsten,

Thanks for the info.

> > The way I got it to build was by downloading flex and bison from: 
> > http://gnuwin32.sourceforge.net
> >   
> Yes, that is necessary. I must get around to updating the 
> documentation.


OK - while you are at it ....

> >
> > Is overlays-version.h supposed to be generated somehow?  Any hints 
> > appreciated...
> >   
> Yes: 
> http://tortoisecvs.cvs.sourceforge.net/viewvc/tortoisecvs/Tort
> oiseCVS/build/utils.sh?r1=1.13&r2=1.14
> 
> You must use the /build/autobuild script at least once.


Can you add that to the doco too?

The place I usually go looking first is:
http://www.tortoisecvs.org/development.shtml

At the moment the way this reads sounds to me as if I only need to
autobuild if I want to make an innosetup:

*Building the installer*

If you want to build the installer, you need Cygwin installed in
addition to an appropriate compiler. Then go to the top folder and run
build/autobuild -h. This will show you the possible parameters you can
use to customize the build process.



> > 6.
> > src/TortoiseShell/ShellExt.cpp refers to <wx/msgcatalog.h> which is 
> > not a part of wxWidgets 2.8 and I cannot find any reference 
> to wxMsgCatalog in the wxWidgets documentation but it is 
> forward defined in the wxLocale class <wx/intl.h> for a 
> return value of private functions -- the comments say 'This 
> is a "low-level" class and is used only by wxLocale'.
> >   
> I had to hack wxWidgets in order to fix a bug where locale changes 
> affected other applications - wxWidgets sets the global 
> locale, which of 
> course is a bad idea in a DLL that can be loaded by arbitrary 
> applications.


OK - some sort of comment about that where the header <wx/msgcatalog.h>
is included in src/TortoiseShell/ShellExt.cpp would probably save a few
questions, plus a note on the doco page...


> That means that your wxWidgets is misconfigured - I will have 
> to check on my build machine which defines to set.

I look forward to hearing ;)

But I'm not convinced that it is entirely the problem.  I checked
similar places in the code where wxAscii() is used (eg: for combobox)
and in all those the .c_str() method was used - so there are only a half
dozen or so places where this is a 'problem' - if it was a wxWidgets
build issue alone I would have expected a much larger breakage...


Regards,


Arthur

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev