Re: [viewvc-dev] [PATCH] Fix exception when generating a tarball from remote repositories

Ceri Storey wrote:
> Eyup.
> 
> I got this exception when trying to make a tarball from a remote repository:
> 
> <h3>An Exception Has Occurred</h3>
> <h4>Python Traceback</h4>
> <p><pre>Traceback (most recent call last):
>   File "/usr/share/viewvc/lib/viewvc.py", line 3630, in main
>     request.run_viewvc()
>   File "/usr/share/viewvc/lib/viewvc.py", line 388, in run_viewvc
>     self.view_func(self)
>   File "/usr/share/viewvc/lib/viewvc.py", line 2937, in download_tarball
>     generate_tarball(fp, request, [], [])
>   File "/usr/share/viewvc/lib/viewvc.py", line 2898, in generate_tarball
>     contents = fp.read()
> TypeError: read() takes exactly 2 arguments (1 given)
> </pre></p>
> 
> So I made the attached patch to fix the signature of the read() method.
> I also notice that it seems to make multiple connections to the remote
> SVN server where one would do, but we can live with that for now.

Patch looks good -- nice catch!

Committed to trunk in r1706.
Backported to the 1.0.x branch in r1707.

Thanks, Ceri.

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFG6od9okEGqRcG/W4RAnu+AJ9LMxDD6IoqjxsTE2nSm6xuwZFCFgCfaqK0
QPfCy8Kc4bVd+DRpsid3bQY=
=HUFh
-----END PGP SIGNATURE-----