Re: [viewvc-dev] svn_ra.py does not URI-escape spaces
"C. Michael Pilato" <[email protected]>
| Newsgroups | gmane.comp.version-control.cvs.viewcvs.devel |
|---|---|
| Organization | CollabNet, Inc. |
| Message-ID | <48161420.1050307__23672.0724883073$1209406570$gmane$org@collab.net> |
C. Michael Pilato wrote: > [email protected] wrote: >> >> >> This causes an issue with a repository like the following: >> \Dir\Subdir\trunk >> \Dir\Subdir 2\trunk >> >> patch supplied > > Jeff, thanks for the bug report and patch. I don't think the patch is > the best one possible. Rather than trying to do IRI-style > auto-escaping, seems we should just be fully URI-escaping the path > portions we're appending to the root URL. I'll take a look at patching > this. I've committed some fixes in r1875. Thanks again for the report. > Also, your patch contained a try/except around svn_ra_get_dir -- what > version of the Subversion bindings are you using which exhibit the problem? (I ask this, by the way, because I'll probably bump the required version of Subversion to 1.4 soon.) -- C. Michael Pilato <[email protected]> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFIFhQgokEGqRcG/W4RAjtwAJwOM4c6nwGbWJVo3RPTbtmCaNjGNgCdFy97 jpJG9H9ixTs5LbnX2N/cu8o= =LJpR -----END PGP SIGNATURE-----