Re: [viewvc-dev] viewvc.branches, viewvc.tags

Philip M. Gollucci wrote:
> C. Michael Pilato wrote:
>> If by "work" you mean it won't croak, sure.  But for other definitions 
>> of "work", I don't see how it can "regardless of the layout chosen".  
>> The chosen layout is the very sticking point we're talking about -- 
>> ignoring it doesn't make the problem go away.
> I don't see how I ignored it :)
> 
>> Yes, in many repositories, you'll find /trunk, /tags, and /branches.  
>> But in many others, you'll find something different (maybe different 
>> projects in the root, with the trunk/tags/branches underneath them).
> Yes, take for example the ASF
> repos/asf/httpd/httpd/{branches,tags,trunk}
> repos/asf/httpd/apreq/{branches,tags,trunk}
> 
> This is why the regex is not anchored with a '^' to start of line.

Ah, gotcha.  I missed that detail in your example.  Sorry.

>> This gets you the ability to treat changes to /trunk/foo and 
>> /branches/my-branch/foo and /tags/foo as all related to the same item 
>> (foo), just on different branches.  This brings parity with CVS, where 
>> branches and tags are orthogonal to path-space.
> Don't you get that either way?
> 
> i.e.
> full path: /repos/asf/httpd/httpd/trunk/server/main.c
> relative   server/main.c
> 
> Given dirs.dir, files.file, branches.branch... Its definitely 
> faster/easier to
> get that if you do it your way :)

Well, I'm not advocating one way or another.  I'm just a design facilitator, 
here.  :-)  Yes, I think you can get this behavior either way.  The only 
question is whether you want convert a full path into a branch-relative one 
up front, or do it for every future query.

Maybe there's middle ground here, where instead of storing, say, an ASF 
branch as just "feature-branch", you store it as 
"/repos/asf/httpd/httpd/branches/feature-branch" (and then remove that 
prefix from the stored dirs).  That way if you need to reconstruct the full 
path, you can do so using branch name + directory name [+ file name].

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIRZZuokEGqRcG/W4RAoCRAJ9zZrj5x+Ieakd5MNUsb1F7ZU5EPwCdFkm6
K+JyohBOdXZr5eP5zCToOgE=
=9G2z
-----END PGP SIGNATURE-----