Re: [viewvc-dev] Re: RSS Feeds built from queries
"C. Michael Pilato" <[email protected]>
| Newsgroups | gmane.comp.version-control.cvs.viewcvs.devel |
|---|---|
| Organization | CollabNet, Inc. |
| Message-ID | <487B7423.3030205__46255.6855906316$1216050279$gmane$org@collab.net> |
Larry Shatzer, Jr. wrote: > On Fri, Jun 20, 2008 at 9:57 AM, Larry Shatzer, Jr. <[email protected] > <mailto:[email protected]>> wrote: [...] > Does anyone else think this would be a worthwile thing to add to > ViewVC (RSS feeds based off the query results)? Yes, I think it worthwhile. > Playing around with this again, and came up with the following patch > (I'm not 100% happy with this one, but it is much simpler), plus it does > not muck around with the template. The only part I am not happy with is > not being able to easily reconstruct the URL and just tack on the format > of rss. Is there a simpler way? This also forces all query result pages > to have the query filtered RSS feed, while the other approach listed > both feeds, and let the user select. I'm torn. There's some value to having "the RSS href" mean the same thing consistently across the various views, so this new approach is in that respect a regression. But then again, if I'm looking a page of query results and I see an RSS icon, I'm naturally going to think that the feed href is related to the query I just performed (in which case your latest approach is The Right Thing). What do others think? Is it fine to declare that rss_href is: - in the query results view, based on the query itself - in other views, based on recent commits to the directory/file ? Or should the definition be always about recent commits, and just add a second RSS feed link to the query results page? And if that's the way we want to go, what do we do about UI presentation? The current feed stuffs are populated from common included EZT template chunks, which means either all templates have to carry the mostly-unused new feed href, or the query view may only present its custom RSS feed href in the "main body" of the HTML output. Thoughts? -- C. Michael Pilato <[email protected]> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFIe3QjokEGqRcG/W4RAgqzAKDRVVbB6f/5djNlFs46TDJm+rbN3QCdHMyB OmrCWnc/QV0xuQFhcoYRvmc= =fWXU -----END PGP SIGNATURE-----