Re: [viewvc-dev] Re: [viewvc-users] Don't display binary files
JJ <[email protected]> Mon, 24 Nov 2008 09:09:16 -0600
| Newsgroups | gmane.comp.version-control.cvs.viewcvs.devel |
|---|---|
| Message-ID | <eed30ed90811240709h3391d651w2b511ae4e453f7c__36670.0848834173$1227539474$gmane$org@mail.gmail.com> |
> > >>>> >>> After thinking this over some more, I decided that only using mime types > instead of file extensions makes sense (i.e. You Were Right!) and is > cleaner. > > Here is a new patch that allows people to either list mime types that > *should* have prefer_markup set (in the prefer_markup_mime_types variable) > or list mime types that *should not* have prefer_markup set (in the > no_prefer_markup_mime_types variable). > > If no values are specified in prefer_markup_mime_types, prefer_markup is > set for *all* mime types. To make this work right I had to use an empty > list as the default value of prefer_markup_mime_types in config.py, but I > still specify text/* in viewvc.conf. That goes against what you said > earlier, but it was a necessary change to default to all mime types, and the > flexibility it provides is quite nice. > > I also maintained the prefer_markup_default variable, which allows people > to specify if prefer_markup should be set for files with no mime type. > > Please let me know what you think. > > JJ > Please let me know if there is anything else I can do to move this patch forward. Thanks, JJ