[viewvc-dev] [PATCH] Fix exception on revision rev request of cvs repository

Kamesh Jayachandran <[email protected]> Wed, 18 Mar 2009 16:07:05 +0530

Newsgroups	gmane.comp.version-control.cvs.viewcvs.devel
Message-ID	<[email protected]>

Hi All,

I could observe the vague exception when revision view is requested on a
 cvs repository.

Attached patch fixes it.

With regards
Kamesh Jayachandran

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=1347273

To unsubscribe from this discussion, e-mail: [[email protected]].

fix.log (text/plain, 186 B)

Fix vague exception when revision view is expected on a cvs repo.

 * lib/viewvc.py
   (view_revision): Raise 'debug.ViewVCException'.

Patch by: Kamesh Jayachandran <[email protected]>

fix.patch (text/plain, 624 B)

Index: viewvc.py
===================================================================
--- viewvc.py	(revision 2102)
+++ viewvc.py	(working copy)
@@ -3194,8 +3194,9 @@
 
 def view_revision(request):
   if request.roottype == "cvs":
-    raise ViewVCException("Revision view not supported for CVS repositories "
-                           "at this time.", "400 Bad Request")
+    raise debug.ViewVCException("Revision view not supported for CVS "
+                                "repositories at this time.", 
+                                "400 Bad Request")
 
   cfg = request.cfg
   data = common_template_data(request)

signature.asc (application/pgp-signature, 252 B)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJwM7U3WHvyO0YTCwRAmhGAJ0V5ZxsadQ5H50IhSwNi4oxZ0xzSgCfU7qy
GIr31PIgdcq1+ctrkk4Xa5g=
=IQB0
-----END PGP SIGNATURE-----