RE: Re: [viewvc-dev] [PATCH] fix exception on mixing url-based and filesystem-based svn repositories

Harald Karner <[email protected]> Fri, 8 May 2009 00:19:15 -0700 (PDT)
Newsgroups gmane.comp.version-control.cvs.viewcvs.devel
Message-ID <12962637.14681001241767155334.JavaMail.httpd__12568.1528159932$1241767176$gmane$org@localhost>
> Are you running under mod_python, by chance?  I'm trying to figure out how
> you're hitting this condition, and the best I can guess is that under
> mod_python you've got the vclib.svn_ra module loaded (with a reference as
> vclib.svn) and then -- because mod_python isn't dumping its module
> collection between displays -- another request that needs to load the real
> vclib.svn bypasses that step and then blows the call to SubversionRepository().
> 
> Does that sound right?

Actually, I was using bin/standalone.py, but apart from that your problem analysis is correct. 

 
> I think the correct fix is to do what I did for ViewVC 1.1.x, which is to
> hide the vclib.ccvs and vclib.bincvs modules behind a single switching
> module (vclib.ccvs) and the vclib.svn and vclib.svn_ra modules behind
> another single switching module (vclib.svn).  Would you agree?

Agreed, the way it's done int the 1.1.x source code would be the cleaner way to fix it.

regards,
Harald Karner

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2107491

To unsubscribe from this discussion, e-mail: [[email protected]].