Re: [viewvc-dev] Various patches for ViewVC

Виталий Филиппов wrote:
>> Sorry for the long delay in response.  Some of these patches seem like
>> they'd be generally useful to the other ViewVC users.  Unfortunately,
>> a "fat
>> patch" would fall on deaf ears at this point.  We haven't the manpower to
>> review and sift through a monolithic, multi-goaled patch like that. 
>> If you
>> are able to break your patch up into smaller, single-focused patches, and
>> post them into our issue tracker as individual issues, though, that'd
>> be great!
> 
> Patches, for example, for mysql UNIX socket support and mysql full text
> search support are overlapping, so they will depend on each other when
> splitted.
> Could you tell which features from the list do you need and which you
> don't? I'll then send you single patches for these features...

All of the items in the list are interesting.  Here are some
comments/questions about a few of them:

> 2) Configurable charset support in annotate, diff, markup views, cvsdb
> and logs

Configurable how?  And is this source encoding specification with forced
conversion to UTF-8 for output?

> 6) Patched ("fast") cvsdbadmin checking file modification times (this
> patch was on your tracker)

I remember this one being controversial... but, as you said, this patch is
already posted.

> 9) Use of python libmagic bindings for determining file content-type

Concerned about performance here, but interested in your approach.

> 10) MIME type checking (configurable regexp) in markup/annotate (for not
> annotating binary files as text ones)

We had a recent lengthy conversation on-list here about MIME types and
binary files and such ... I'm a little leery of adding more complexity in
this area, but again, it's easier to evaluate an approach than to speak in
generalities.

> 11) Shell scripts for ViewVC deployment on a Linux (tested on Debian)
> version control server

What's this?  /etc/init.d stuff for standalone.py or somesuch?

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2314724

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkoS18sACgkQokEGqRcG/W5XRQCgzYCNykgHOYJWMvtv5cFE41qQ
vRIAnjO1jSTDZMy6e6762OkmXuzlyrv9
=d9Tt
-----END PGP SIGNATURE-----