Re: [viewvc-dev] [PATCH] Fix issue #407

Senthil Kumaran S wrote:
> Hi,
> 
> I am attaching a patch in order to fix issue #407.
> 
> [[[
> Fix issue #407.
> 
> * lib/viewvc.py
>   (get_itemprops): Add regular expression to identify a URL in the
>    property value and use that to substitute it with a link.
> 
> Patch by: Senthil Kumaran S <[email protected]>
> ]]]

Hey, Senthil.  Nice to see you over on this list!

ViewVC already has a regular expression for identifying URLs (the
perhaps-not-ideally-named _re_rewrite_url).  Along those lines, I wonder if
a better approach would be to slam the property values through an
HtmlFormatter class instance (perhaps by using format_log()) so that URLs
and email addresses (and issue ids, for folks that have customized ViewVC to
recognize those) are all marked up in the same way that log messages are.
Thoughts?

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2409811

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkrfIGkACgkQokEGqRcG/W676wCfV05UFApjypViXZjpxJpNMaGV
YEkAmwZcoa9OtHSi6dCWBZL70pXHSrU1
=fAyK
-----END PGP SIGNATURE-----