[viewvc-dev] Re: svn commit: r2620 - branches/property-diff/lib/viewvc.py

On 10/16/2011 02:48 AM, [email protected] wrote:
> Author: stilor
> Date: 2011-10-15 23:48:47-0700
> New Revision: 2620

[...]

> Modified: branches/property-diff/lib/viewvc.py
> Url: http://viewvc.tigris.org/source/browse/viewvc/branches/property-diff/lib/viewvc.py?view=diff&pathrev=2620&r1=2619&r2=2620
> ==============================================================================
> --- branches/property-diff/lib/viewvc.py	(original)
> +++ branches/property-diff/lib/viewvc.py	2011-10-15 23:48:47-0700
> @@ -3250,29 +3250,34 @@
>    ago = log_entry.date is not None \
>           and html_time(request, log_entry.date, 1) or None
>    path_joined = _path_join(path_comp)
> -  i_bare = _item(date=make_time_string(log_entry.date, request.cfg),
> -		 author=log_entry.author,
> -		 log=format_log(request, log_entry.log),
> -		 size=log_entry.size,
> -		 ago=ago,
> -		 path=path_joined,
> -		 rev=rev,
> -		 tag=sym,
> -		 view_href=None,
> -		 download_href=None,
> -		 download_text_href=None,
> -		 annotate_href=None,
> -		 revision_href=None,
> -		 prefer_markup=ezt.boolean(0))
> +  # Item for property diff: no hrefs, there's no view to download/annotate property
> +  i_prop = _item(log_entry=log_entry,
> +      date=make_time_string(log_entry.date, request.cfg),
> +      author=log_entry.author,
> +      log=format_log(request, log_entry.log),
> +      size=log_entry.size,
> +      ago=ago,
> +      path=path_joined,
> +      path_comp=path_comp,
> +      rev=rev,
> +      tag=sym,
> +      view_href=None,
> +      download_href=None,
> +      download_text_href=None,
> +      annotate_href=None,
> +      revision_href=None,
> +      prefer_markup=ezt.boolean(0))

There appears to be a formatting change here not mentioned in your log
message.  While that's not earth-shattering, it did draw my attention to the
presence of tabstops which you've introduced into the codebase.  Tabstops in
ViewVC Python code is a big no-no, so please ensure that those get converted
into space character runs.  Also, please do your best to maintain local code
formatting/indentation conventions (which such can be reasonably
determined).  So, for example:

i_prop = _item(log_entry=log_entry,
               date=make_time_string(log_entry.date, request.cfg),
               author=log_entry.author,
               log=format_log(request, log_entry.log),
               ...

Other than such nitpicking, your changes are looking great --
well-organized, purposeful, and much-appreciated!  Thanks!

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2857776

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk6cSXYACgkQokEGqRcG/W4/qACgn8aXpY+1I53CQL5BD6nfA1Ar
p2MAoKA+LFsB/w/Tmkd33k8gRVasmECC
=i7tF
-----END PGP SIGNATURE-----