Re: [viewvc-dev] svn commit: r2626 - branches/property-diff: lib templates

On Monday, October 17, 2011 08:37:21 am C. Michael Pilato wrote:
> On 10/16/2011 03:02 PM, [email protected] wrote:
> > Author: stilor
> > Date: 2011-10-16 12:02:32-0700
> > New Revision: 2626
> > 
> > Modified:
> >    branches/property-diff/lib/viewvc.py
> >    branches/property-diff/templates/log.ezt
> > 
> > Log:
> > * viewvc.py
> > 
> >   (Request.run_viewvc): Select diff view for directories if r1/r2
> >   arguments are provided.
> >   (view_revision): Generate a link to diff view on directories if there
> >   was a change in properties.
> 
> Hrm...  we might want to think through this one a bit.  Will this same URL
> format grow into a fully recursive directory diff in the future?  Do we
> anticipate the need for specifying the depth of a directory diff
> (recursive/non-recursive, depth-zero/depth-infinity, etc.)?

Yes, I thought "&recursive=1" would be selecting the recursive diff, and the 
link would look like:

  Diff to previous 1234 (recursive)

Where "previous 1234" links to a diff of the directory itself (as it does now) 
and "recursive" links to the, eh, recursive diff.

I don't think depth specification for diff would have much use. It is very 
useful for sparse check-outs, but for diffs? I don't think so.

Regards,
Alexey.

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2857806

To unsubscribe from this discussion, e-mail: [[email protected]].