Re: [viewvc-dev] Question regarding DiffSource()

On 10/17/2011 12:47 PM, Alexey Neyman wrote:
> Thing is, I am not sure if it is a bug or feature. To me, marking such lines 
> as removed and readded looks counterintuitive, but with the explicit handling 
> of this case, I think the original author thought otherwise.

The unidiff format is inherently lossy regarding the semantics of a
modification, as a "changed line" is decomposed into the two primitives -- a
removed line and an added line.  As you know, ViewVC naively attempts to
re-compose those primitives when it finds them together without intervening
unmodified context.  Of course, we humans do the same thing mentally (though
we probably tend to apply more thorough heuristics based on the actual
details of the modifications).

I guess my point is, there's no additional real loss of information in
choosing to display this information as "changed lines" versus
"removed/added lines".  So if you feel that one way is more intuitive for
users, and we are confident that we can make the code behave that way
without introducing another bug elsewhere, then let's make the change.

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2858828

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk6e0s8ACgkQokEGqRcG/W4+mwCgurnEcAifrya8K+SLNgQ/ArPX
QM8An1BWgzL99oZ3SGp8vbW7pOXZtB/D
=Rv6X
-----END PGP SIGNATURE-----