Re: [viewvc-dev] Is this property-diff branch ready for reintegration?

On 10/27/2011 01:43 PM, Alexey Neyman wrote:
> On Thursday, October 27, 2011 06:17:23 am C. Michael Pilato wrote:
>> Yes, it does.  I'd forgotten about all those crazy variables ... what a
>> mess.  My instinct is to still shudder at the idea of the ViewVC libs
>> dictating to the UI layer about UI-ish things...  but then again, this is
>> really the only way that EZT can know about the user-selected requested
>> diff format.  So I'm okay with leaving it as-is.
> 
> Well, maybe a better name for 'display_as' would be 'diff_block_format' or 
> something like that. It doesn't actually tell template how to display the 
> block, it tells the template what the block contains.

Ha!  I was actually going to suggest calling it "diff_format", but didn't
want to overload the "diff_format" term (as it's used in the CGI parameter
space).  +1 on renaming to "diff_block_format", though.  You want to make
that change (on trunk)?

> Thanks for merging the branch back to trunk!

...and thanks to you for the work, and for reminding me just now that I
didn't delete the now-reintegrated branch.

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2865429

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk6pnjAACgkQokEGqRcG/W4YYACeKCRnFgywouSwESe9xE89jk08
/QUAn1U6+HyCVPdxDAWfxfeJPHckAN4J
=d0d9
-----END PGP SIGNATURE-----