Re: [viewvc-dev] r2674 (Fix annotate views using urllib.pathname2url) breaks annotate on windows

------=_Part_22309_1271198562.1325604302123
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable

On 12/30/2011 05:08 AM, Jens Peters wrote:
> Hello there,
>=20
> While testing the current 1.1 branch on a windows box I could not see=20
> annotations. After some investigation it looks like r2675/r2674 is the=20
> reason. On windows the rootpath looks like '/d:/svn/repos'. Obviously=20
> urllib.pathname2url does not like a path segment like that.
>=20
> Unfortunately I don't know beter solution to your original issue :(=20
>=20
> Regards,
> Jens

Thanks for the report, Jens!  Man, I feel like I'm playing whack-a-mole wit=
h
that section of code...

I've taken yet another crack it in r2707 (r2708 on the 1.1.x branch).  Coul=
d
you give the code a spin in your Windows environment?

Obviously I'd like annotations to work *at all* in Windows.  But I'm also
trying to ensure that they work when either or both of the "on-disk path to
the repository" and "versioned file path inside the repository" have
URI-unsafe characters (spaces, for example).

Thanks!

--=20
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=3D4251&dsMessageId=3D2=
905637

To unsubscribe from this discussion, e-mail: [[email protected]=
.org].
------=_Part_22309_1271198562.1325604302123
Content-Type: application/pgp-signature; name=signature.asc
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=signature.asc
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk8DHb4ACgkQokEGqRcG/W5+qACfRVXCEbN7KR8B3ci+Kmb6H2GD
s0sAni95zTyeNiO+zDL84afsKozUH9hp
=TC4A
-----END PGP SIGNATURE-----

------=_Part_22309_1271198562.1325604302123--