Re: [viewvc-dev] viewvc-1.1.16: UnboundLocalError: local variable 'log_pagestart' referenced before assignment

------=_Part_12969_391119570.1351172326878
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable

I can confirm this problem, and apologize for the sloppy coding. :-(

This patch should fix the bug:

Index: lib/viewvc.py
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- lib/viewvc.py=09(revision 2803)
+++ lib/viewvc.py=09(working copy)
@@ -2551,6 +2551,7 @@
       sortby =3D vclib.SORTBY_DEFAULT

   first =3D last =3D 0
+  log_pagestart =3D None
   if cfg.options.log_pagesize:
     log_pagestart =3D int(request.query_dict.get('log_pagestart', 0))
     total =3D cfg.options.log_pagesextra * cfg.options.log_pagesize


On 10/25/2012 01:20 AM, olli hauer wrote:
> After upgrade to viewvc-1.1.16 I get the error below,
> downgrade back to 1.1.15 issue went away.
>=20
> - Browsing the repo OK until a single file is selected.
> - /viewvc/trunk/CHANGES?view=3Dmarkup =3D> working
> - /viewvc?view=3Drevision&revision=3D2806 =3D> working
> - /viewvc?view=3Drevision&revision=3D2806 -> select [trunk/CHANGES] =3D> =
working
> - /viewvc?view=3Drevision&revision=3D2806 -> select [modified] =3D> error
> - /viewvc?view=3Drevision&revision=3D2806 -> select [text changed] =3D> w=
orking
>=20
> Python version: python 2.7.3
> Pygments version: pygments-1.5
>=20
>=20
> Python Traceback
>=20
> Traceback (most recent call last):
>   File "/usr/local/viewvc/lib/viewvc.py", line 4675, in main
>     request.run_viewvc()
>   File "/usr/local/viewvc/lib/viewvc.py", line 395, in run_viewvc
>     self.view_func(self)
>   File "/usr/local/viewvc/lib/viewvc.py", line 2678, in view_log
>     'log_pagestart': log_pagestart},
> UnboundLocalError: local variable 'log_pagestart' referenced before assig=
nment
>=20
>=20
> // olli
>=20
> ------------------------------------------------------
> http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=3D4251&dsMessageId=
=3D3023337
>=20
> To unsubscribe from this discussion, e-mail: [[email protected]=
is.org].
>=20


--=20
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=3D4251&dsMessageId=3D3=
023444

To unsubscribe from this discussion, e-mail: [[email protected]=
.org].
------=_Part_12969_391119570.1351172326878
Content-Type: application/pgp-signature; name=signature.asc
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=signature.asc
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJQiUDiAAoJEPXg8AH+aBMzz5QQAIp5VaCOeEW/YNR4xOdbQ4nm
KwnXvil2UBaHSjeXOXGcqI7GqZsKARrnHCku5lC/carzQO5EbtM5/+E4ykY4S8aP
81al5undYtpMiM0oLEEM8v5uXQ1iwkpiCfQQgcg6UzEvKak3/+aGt4SEcn5Z63RU
Z54lthP6supM4jtN1VTLzlVwwRgLuqxiza+n8TAp2fHL5RZdKQ4bDgYHF3l4FHaR
JoMI6aZltZVLrbWZIeaXXNBNCRAg4lwTsZoBihYWdK2nuaeqzbFykOz/IAVAjIQZ
P9RA94BgbDMPcOQMI+rwUGz7xoT2fYWZvvUaM2oy0abVbs/bO1DGCaBNKrsbkYs7
P2xvCZkmD6cNGbLy0BXljOG3d0Wsv5JW2bN17FJkD/V5izSjI8/oiD1o8iwMmuBF
Unh2X3ZA6fhTwpnWJMTY+OS8JZInY8mhCtUYv5V0RDhx1lYbyPEUU8JvmtNA+spO
HtjFkf0+OeSYiOpZQ3jFViAgHzUL1Wdh2mpiZLjUXPfGtiNtWZHLLBuWjjOr2nog
HAyv5c/67RRPxQLfbDKf3f8AWwLWagvpz8VyZ4tBH7QSaEvpIqNhVCNuDKXtawC1
xNDxnQqzVS5i4eVEDiLY7Bshe53LzZCBsjksXdhF2VnTwIZnI/AHtDnQGGYXtxEk
RrgIY0YZUoynwFpEjc5w
=iWYs
-----END PGP SIGNATURE-----

------=_Part_12969_391119570.1351172326878--