[viewvc-users] cvsdp.py - commit revision number truncated

Hello ViewVC people,

Not sure if this is a bug as such, but ...

The CVS revision number of a file I'm working on has reached
1.2.2.30.10.6.4.98.4.77.6.110.4.2 (which is 33 characters).

On committing this to CVS, I received:

/usr/lib/viewvc/cvsdb.py:262: Warning: Data truncated for column 
'revision' at row 1
   cursor.execute(sql, sql_args)

Luckily, nothing too bad (in this case, anyway) seems to have
happened in ViewVC as a result - other than the inability to
distinguish between this revision and the previous revision in
the "Query Results" screen after using the "Query Revision History"
feature - the revision numbers are (unsurprisingly) truncated both
in the links and as displayed.

However, 32 characters does seem to possibly be a little on
the low side for the maximum size of a CVS revision number -
would it be possible to increase it in future releases?

A peek at the schema suggests it's a varchar - so increasing
the limit shouldn't waste any space on most DBs I guess.

A quick and dirty "grep" of a few of the heaviest used parts of
our repository suggests that our longest revision number is
about 42 characters. Perhaps 50 or so is a more realistic maximum?

I don't think our usage of CVS is too unusual; I guess the number
does suggest we've created rather more branches of branches than
we've merged back in, but I think that's to be expected over a period
of 10 years of usage.

Cheers,
Kieran Elby

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=1509610

To unsubscribe from this discussion, e-mail: [[email protected]].