Re: [viewvc-users] Error Viewing Diffs

Lawrence, I'm not sure how you're hitting this problem with the default
template set.  If you're comfortable making a small change to your ViewVC
source code, could you try the following patch:


Index: lib/viewvc.py
===================================================================
--- lib/viewvc.py	(revision 2249)
+++ lib/viewvc.py	(working copy)
@@ -3187,7 +3187,8 @@
   else:
     date1 = date2 = flag = headers = None

-  raw_diff_fp = changes = None
+  raw_diff_fp = None
+  changes = []
   if fp:
     if human_readable:
       if flag is not None:


(Let me know if you don't understand what the above means.)

Lawrence Cutlip-Mason wrote:
> This seemingly happens randomly, but is consistent on certain version diffs.
> 
> 1) View File Revisions
> 2) Select one of the revisions for diffing
> 3) Click diff to selected revision
> 4) Python Error (see bottom)
> 
> ---------
> Items of note:
> -Windows 2003 R2
> -Python 2.4.1
> -ViewVC 1.1.2
> -Pygments 1.0
> -Happens only when comparing certain revisions and not others, 100% repeatable and consistent on which ones it works and which ones it doesn't (about 75% of the revisions/files it fails).
> -Regular View with syntax highlighting works fine
> -See attached viewvc.conf
> ---------
> 
> ===------ERROR:------====
> Traceback (most recent call last):
>   File "e:\viewvc\lib\viewvc.py", line 4114, in main
>     request.run_viewvc()
>   File "e:\viewvc\lib\viewvc.py", line 398, in run_viewvc
>     self.view_func(self)
>   File "e:\viewvc\lib\viewvc.py", line 3047, in view_diff
>     generate_page(request, "diff", data)
>   File "e:\viewvc\lib\viewvc.py", line 913, in generate_page
>     template.generate(server_fp, data)
>   File "e:\viewvc\lib\ezt.py", line 329, in generate
>     self._execute(self.program, ctx)
>   File "e:\viewvc\lib\ezt.py", line 458, in _execute
>     step[0](step[1], ctx)
>   File "e:\viewvc\lib\ezt.py", line 490, in _cmd_if_any
>     self._do_if(value, t_section, f_section, ctx)
>   File "e:\viewvc\lib\ezt.py", line 522, in _do_if
>     self._execute(section, ctx)
>   File "e:\viewvc\lib\ezt.py", line 458, in _execute
>     step[0](step[1], ctx)
>   File "e:\viewvc\lib\ezt.py", line 528, in _cmd_for
>     raise NeedSequenceError("The value of '%s' is not a sequence"
> NeedSequenceError: The value of 'changes' is not a sequence


-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=2386756

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqSsIQACgkQokEGqRcG/W5KQACgwg9OiRvRKwncQPlxj+S78w6V
S/0AnjOzqoSWZsGnwsOtGpa9GrVcl99d
=2gxm
-----END PGP SIGNATURE-----