Re: [viewvc-users] Binary Files open in browser as garbage.

Raghu Kumar C wrote:
> Michael,
> 
> 	I apologise for this late reply. I didn't see you reply and I am
> surprised how I missed out. It could be that I didn't receive it or I
> would have accidentally deleted it. Please read this link for reference:
> http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=23
> 87121&orderBy=createDate&orderType=desc 
> 
> I don't have 'co' in my list of allowed_views. I would like to mention
> that the 'download' link has "view=markup" which is already enabled in
> my allowed_views.

I suspect that the reason that it appears that the download link has
"view=markup" and appears to just refresh the page is because the link in
the HTML looks like:

   <a href="">

That is, it has no target href.  The browser is just going to treat that as
 a self-reference.

And the cause is my fault.  I wrote that file.ezt template logic to always
recommend the download view even when that view is not available (due to
"co" not being in the allowed_views list).

I've just committed a fix for this.  Now, if the template is setup to hide
binary file contents, and the "co" (checkout/download) view is disabled in
viewvc.conf, the template will say, "This file's contents are not viewable."
but will *not* go on to recommend using the download view.

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=2392944

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqnvtQACgkQokEGqRcG/W6D8wCePNv0llEUhH/rLlxH4kkz8vgd
WC4AoLFOTSFtGKhyKH5yVfhQQE57kN5+
=XswL
-----END PGP SIGNATURE-----