Re: [viewvc-users] incomplete data from query

Your spelunking has been useful, and has identified a problem.  ViewVC has
the following configuration options:  'row_limit' (which defaults to 1000),
'rss_row_limit' (which defaults to 100), and 'limit_changes' (which defaults
to 100).  It appears the codebase is using rss_row_limit to limit query
results when in RSS mode, which is correct.  But rather than use row_limit
for non-RSS query, it's using limit_changes instead.  That's confusing at a
minimum, but probably closer to Just Plain Wrong(tm).

Of course, the UI is *supposed* to tell the user when the results have been
limited and allow them to override that (by clicking a link that results in
"&limit=0" being added to the query URL).  If that's not happening, then
that is a second bug.

I'm about to hop on a plane from the U.S. to Germany.  Would you be
willing/able to file an issue in the ViewVC issue tracker about this matter,
copying into the issue any info from this thread that's relevant?   Thanks,
David.


David Carson wrote:
> I put 1.1.3-dev on a test machine, same results.  Now I am trying to look
> through the code for some clues.
> 
> I added a debug statement to write out the sql query being formed by the
> "query rev history" form.  What I get is a query that includes a "LIMIT
> 1000" clause.  Is this coming from the row_limit parameter in the config
> file?  I tried increasing it to 10000, but I was surprised to see that
> the results were still the same.
> 
> Either the code queries iteratively to gather _all_ the data, or this
> LIMIT is going to cause invalid results, right?  The query is returning
> one record for each changed path within a given commit (I think), so this
> 1000 record limit will be exhausted very quickly.
> 
> What is a reasonable row_limit (if indeed this is what I need to change)?
> Also, and more importantly, how is the user supposed to know when the
> limit is exceeded by what the query could have returned?  This would at
> least tell the user that the query was too big and only part of the
> results were returned.
> 
> Thanks, David
> 
> 
>> I upgraded to 1.1.2.  No change, still returns only a few recent
>> entries.
>> 
>>> - version: 1.1.1 - repository: SVN 1.6.x (fsfs), with usual
>>> trunk/tags/branches setup.
>>> 
>>> I navigate into .../branches/widget, then click on "query revision
>>> history" and ask for all changes since the beginning of time.  The
>>> result is only a few entries, instead of 50 or more.
>>> 
>>> If I revise the query to filter on one userid, for example, I can get
>>> an entry that did not appear in the first query, even though it
>>> should have.
>>> 
>>> This does not seem to happen for all branches.
>>> 
>>> I have also gone into the database itself using a db browser.  I can
>>> see that there are many more entries for the widget path than the
>>> results are giving me.
>>> 
>>> What could be going on?  What further information might be helpful in
>>> debugging?
>>> 
>>> Thanks, David
> 
> ------------------------------------------------------ 
> http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=2411054
> 
> 
> To unsubscribe from this discussion, e-mail:
> [[email protected]].


-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=2411057

To unsubscribe from this discussion, e-mail: [[email protected]].