RE: Re: [viewvc-users] forbiddenre not quite working

Dave Holland <[email protected]>
Newsgroups gmane.comp.version-control.cvs.viewcvs.user
Message-ID <153208506.28897.1274876794837.JavaMail.httpd@localhost>
(hmm, reply-by-email seems to have put an empty message in the web interface - I'll reply here)

Fair point - I'd disabled use of the web proxy but not thought about etags etc, thanks. Unfortunately setting those variables didn't help.

I'm not fluent in Python. However, it appears that is_forbidden isn't being called anywhere in the view_roots code path. Here's a pretty crude hack that that calls is_forbidden in load_config, which is probably the wrong place to do it, and (I think) isn't sensible if you use forbidden rather than forbiddenre. I think it would be better to put the check in view_roots but I don't know enough Python to unpick the data structures there. Help, please?

Cheers,
Dave

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=2613628

To unsubscribe from this discussion, e-mail: [[email protected]].
viewvc-forbiddenre-patch (application/octet-stream, 1.8 KB) - not displayed
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.