Re: [viewvc-users] co/download option for allowed_view in viewvc.conf

On 07/08/2011 11:07 AM, wayne chan wrote:
> hi viewvc discussion group,
> 
> i am puzzled about the download and co options for allowed_view in
> viewvc.conf file. When both options are set there is no "co" tab in the
> top menu bar but "download" tab. If i click "download" against a
> directory object then i got the download dialog box prompting for
> download location on my local system. If i click "download" against a
> file object then i got the file content displayed on my browser.
> 
> If allowed_view is setup without "co" option the "download" tab is
> available only for directory object and disappear when i navigate to file
> object page.
> 
> This leads me to conclude the "download" and "co" options on allowed_view
> share the same "download" tab interface. But "co" option only works
> against file object and its function is to display the target file
> content in svn "check-out" format !! It has nothing to do with svn
> checkout action at all.
> 
> Is the above the correct behavior of "download" and "co" options setting
> for allowed_view in viewvc.conf ??

Some of your confusion stems from the fact that "download" is not a valid
value for the allowed_views configuration option.  :-)  This from
viewvc.conf.dist:

  ## allowed_views: List the ViewVC views which are enabled.  Views not
  ## in this comma-delited list will not be served (or, will return an
  ## error on attempted access).
  ## Possible values: "annotate", "co", "diff", "markup", "roots", "tar"
  ##

Behaviorally, "download" and "co" mean exactly the same thing and are used
somewhat interchangeably (for good or for ill).  I'm not sure why you see a
download option at all for directories -- that's just weird.  Can you
demonstrate this with some publicly available ViewVC instance so we can try
to see what you're seeing?

As for your conclusion, you are basically correct.  It's a "checkout view"
-- that is, what you would see if you checked out the file (presumably named
for the RCS "co" helper program) -- not itself a version control checkout
operation.

This has caused confusion for others, too.  As such, I've filed issue #490
to track some terminological cleanup in this space.
http://viewvc.tigris.org/issues/show_bug.cgi?id=490

Thanks for the report!

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=2788110

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk4XL/wACgkQokEGqRcG/W55LgCeMZ3f+HMr6rwL27Rpt2kTZtzX
VFgAn0fLqo7vqV+jjzimkFwk3ZjhNLW5
=Twa2
-----END PGP SIGNATURE-----