Re: [viewvc-users] /tmp filling up with tempfile.*.tmp; annotate pdf's?

On 08/29/2012 07:07 PM, Karl Berry wrote:
> Thanks for the quick reply.
> 
>     No, the SIGTERM handler doesn't appear to do what I thought it would,
>     so it's already been removed from ViewVC's trunk code.
> 
> Aside: So viewvc can't catch SIGTERM to remove the temp files?
> I'm surprised.  But if I knew more I probably wouldn't be :).

That handler was put in place to try to help BerkeleyDB-backed Subversion
repositories not get wedged.  But all modern Subversion versions using even
remotely modern Berkeley DB versions can already handle this situation more
gracefully without the extra help.  (And besides, almost nobody uses
BerkeleyDB for their Subversion backends any more anyway.)  What I didn't
know at the time was that the handler interfered with mod_python in some
negative fashion (and I can't even recall the details now).  At any rate, I
pulled the handler out for those reasons.

>       # show links to content views (markup, annotate, diff) for files which
>       # not human-readable (so-called binary files)?
>       view_binary_files = 1
> 
> Not that it matters for my purposes, but I would consider making the
> default be zero.  I know it would be an incompatible change, but think
> of all the wasted network bandwidth that would be saved :).
> Annotating/etc. binary files can't possibly be useful, as far as I can
> imagine.
> 
>       # list of MIME content types (with support for fnmatch-style glob
>       # characters) which are considered human-readable.
>       viewable_mime_types = text/*, application/xml
> 
> This would be workable, but I'd feel safer specifying the non-viewable
> mime types.  I'd start with application/pdf and application/octet-stream
> and see how things went.  That way I'd know that nothing else I didn't
> know about was affected.
> 
> Mime types of "text" files can get pretty random, in my experience, and
> I'd rather err on the side of having useless links than omitting useful
> ones.

Perhaps only a single new configuration option is required, then?

   # List of MIME content types (with support for fnmatch-style glob
   # characters) which are considered not-human-readable and for which
   # ViewVC will neither generate links to, nor support the direct display
   # of, views with carry the file's content ('markup','annotate', and
   # 'diff' views).
   #
   # Example(s):
   # unviewable_mime_types = image/*, application/pdf, application/msword
   #
   unviewable_mime_types =

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=3002206

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAlA/cx8ACgkQokEGqRcG/W5QjACeK5/Eg0mml40f0Z5IymhQOJkg
n8UAniAqD1q8ZtLS8beABF29rXvjL/9z
=aOvB
-----END PGP SIGNATURE-----