Re: [viewvc-users] firefox update seems to have broken viewvc

On 10/21/2014 12:41 PM, C. Michael Pilato wrote:
> On 10/21/2014 10:33 AM, David Laight wrote:
>> From: C. Michael Pilato
>>> Hrm.  I can't think of any reason why whitespace would be rendered
>>> differently in Firefox 33.0.  I'm able successfully view a local ViewVC
>>> 1.1.5 installation using Firefox 33.0 (Ubuntu Linux), in fact.  Have you
>>> tried clearing out your browser caches?
>> Someone here who knows more about browsers discovered that the style sheet
>> wasn't being applied, the found that it is probably this bug:
>>
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1083090
>>
>>
>> Seems firefox tightened up on rejecting bad/mismatched headers on css and js.
>> Solution is to disable on-the-fly compression of the stylesheet at the server end.
>>
>> So Mozilla have just broken a lot of web sites.
> David, thanks for feeding this information back into the community. 
> There have been some problems in the past with compression in ViewVC,
> and some fixed since 1.1.5, even.  I'll look into the codebase to see if
> perhaps some double-compression is happening with the stylesheets in
> 1.1.5.  In the meantime, you might want to set allow_compress=0 in your
> viewvc.conf file.

Through some code spelunking I was able to determine that there was a
reason some of this seemed familiar to me.  Via ViewVC issue #467
(http://viewvc.tigris.org/issues/show_bug.cgi?id=467) I made a fix to a
compression-related bug that, at the time, was manifesting as extreme
slowness.  It seems that that same bug manifests today as ignored CSS in
the new Firefox.  (And I was able to confirm as much locally using the
additional clues you provided.)  The fix for this problem was released
in ViewVC 1.1.8, and I can confirm that the code remains functionality
in ViewVC 1.1.22.  But again, toggling allow_compress=0 in your
viewvc.conf file should work around the problem without requiring you to
upgrade ViewVC.

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4255&dsMessageId=3090251

To unsubscribe from this discussion, e-mail: [[email protected]].